You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/09/05 16:48:55 UTC

Review Request 25389: API retruns filed "display_name" = null, for Zookeeper Client

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25389/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7173
    https://issues.apache.org/jira/browse/AMBARI-7173


Repository: ambari


Description
-------

/api/v1/stacks/HDP/versions/2.1/services?fields=StackServices/**,serviceCompon
ents/**

This request returns (for zookeeper client) :

    
    
    
     "serviceComponents" : [
            {
              "href" : "http://slider-1:8080/api/v1/stacks/HDP/versions/2.1/services/ZOOKEEPER/components/ZOOKEEPER_CLIENT",
              "StackServiceComponents" : {
                "cardinality" : "1+",
                "component_category" : "CLIENT",
                "component_name" : "ZOOKEEPER_CLIENT",
                "custom_commands" : [ ],
                "display_name" : null,
                "is_client" : true,
                "is_master" : false,
                "service_name" : "ZOOKEEPER",
                "stack_name" : "HDP",
                "stack_version" : "2.1"
              },
              "dependencies" : [ ]
            },
    

**"display_name" : null,**  
This issue creates bug described in BUG - 21889, and can cause issues all over
ambari web where we use that field.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml 2b1bfdb 

Diff: https://reviews.apache.org/r/25389/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 25389: API retruns filed "display_name" = null, for Zookeeper Client

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25389/
-----------------------------------------------------------

(Updated Sept. 5, 2014, 3:26 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7173
    https://issues.apache.org/jira/browse/AMBARI-7173


Repository: ambari


Description (updated)
-------

/api/v1/stacks/HDP/versions/2.1/services?fields=StackServices/**,serviceCompon
ents/**

This request returns (for zookeeper client) :

    
    
    
     "serviceComponents" : [
            {
              "href" : "http://slider-1:8080/api/v1/stacks/HDP/versions/2.1/services/ZOOKEEPER/components/ZOOKEEPER_CLIENT",
              "StackServiceComponents" : {
                "cardinality" : "1+",
                "component_category" : "CLIENT",
                "component_name" : "ZOOKEEPER_CLIENT",
                "custom_commands" : [ ],
                "display_name" : null,
                "is_client" : true,
                "is_master" : false,
                "service_name" : "ZOOKEEPER",
                "stack_name" : "HDP",
                "stack_version" : "2.1"
              },
              "dependencies" : [ ]
            },
    

**"display_name" : null,**  
This issue creates bug described somewhere else, and can cause issues all over
ambari web where we use that field.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml 2b1bfdb 

Diff: https://reviews.apache.org/r/25389/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 25389: API retruns filed "display_name" = null, for Zookeeper Client

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25389/#review52457
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Sept. 5, 2014, 2:48 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25389/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 2:48 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7173
>     https://issues.apache.org/jira/browse/AMBARI-7173
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> /api/v1/stacks/HDP/versions/2.1/services?fields=StackServices/**,serviceCompon
> ents/**
> 
> This request returns (for zookeeper client) :
> 
>     
>     
>     
>      "serviceComponents" : [
>             {
>               "href" : "http://slider-1:8080/api/v1/stacks/HDP/versions/2.1/services/ZOOKEEPER/components/ZOOKEEPER_CLIENT",
>               "StackServiceComponents" : {
>                 "cardinality" : "1+",
>                 "component_category" : "CLIENT",
>                 "component_name" : "ZOOKEEPER_CLIENT",
>                 "custom_commands" : [ ],
>                 "display_name" : null,
>                 "is_client" : true,
>                 "is_master" : false,
>                 "service_name" : "ZOOKEEPER",
>                 "stack_name" : "HDP",
>                 "stack_version" : "2.1"
>               },
>               "dependencies" : [ ]
>             },
>     
> 
> **"display_name" : null,**  
> This issue creates bug described in BUG - 21889, and can cause issues all over
> ambari web where we use that field.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml 2b1bfdb 
> 
> Diff: https://reviews.apache.org/r/25389/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>