You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Mithun Mathew <mi...@gmail.com> on 2015/10/13 03:54:56 UTC

Review Request 39256: HAWQ gpcheck configuration category view on HAWQ configurations page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39256/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-13350
    https://issues.apache.org/jira/browse/AMBARI-13350


Repository: ambari


Description
-------

HAWQ gpcheck configuration was being shown as 'Advanced gpcheck.cnf' in the HAWQ Configuration settings page. This patch ensures that the gpcheck configurations are shown in a separate category called 'Advanced gpcheck' which is collapsed by default.


Diffs
-----

  ambari-web/app/data/HDP2.3/site_properties.js 70fc4f2 
  ambari-web/app/models/stack_service.js 9541b36 

Diff: https://reviews.apache.org/r/39256/diff/


Testing
-------

Manually tested.

Ran mvn test on ambari-web directory.


Thanks,

Mithun Mathew


Re: Review Request 39256: HAWQ gpcheck configuration category view on HAWQ configurations page

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39256/#review102684
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On Oct. 13, 2015, 1:54 a.m., Mithun Mathew wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39256/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 1:54 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-13350
>     https://issues.apache.org/jira/browse/AMBARI-13350
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HAWQ gpcheck configuration was being shown as 'Advanced gpcheck.cnf' in the HAWQ Configuration settings page. This patch ensures that the gpcheck configurations are shown in a separate category called 'Advanced gpcheck' which is collapsed by default.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/HDP2.3/site_properties.js 70fc4f2 
>   ambari-web/app/models/stack_service.js 9541b36 
> 
> Diff: https://reviews.apache.org/r/39256/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> Ran mvn test on ambari-web directory.
> 
> 
> Thanks,
> 
> Mithun Mathew
> 
>


Re: Review Request 39256: HAWQ gpcheck configuration category view on HAWQ configurations page

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39256/#review102667
-----------------------------------------------------------


Please include Jaimin Jetly in the code review.

- Alejandro Fernandez


On Oct. 13, 2015, 1:54 a.m., Mithun Mathew wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39256/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 1:54 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-13350
>     https://issues.apache.org/jira/browse/AMBARI-13350
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HAWQ gpcheck configuration was being shown as 'Advanced gpcheck.cnf' in the HAWQ Configuration settings page. This patch ensures that the gpcheck configurations are shown in a separate category called 'Advanced gpcheck' which is collapsed by default.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/HDP2.3/site_properties.js 70fc4f2 
>   ambari-web/app/models/stack_service.js 9541b36 
> 
> Diff: https://reviews.apache.org/r/39256/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> Ran mvn test on ambari-web directory.
> 
> 
> Thanks,
> 
> Mithun Mathew
> 
>