You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/13 08:40:56 UTC

[GitHub] [iotdb] HeimingZ opened a new pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

HeimingZ opened a new pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799


   Current time partition function is imperfect, suggest disabling it by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799#issuecomment-1011972528


   
   [![Coverage Status](https://coveralls.io/builds/45599146/badge)](https://coveralls.io/builds/45599146)
   
   Coverage increased (+0.1%) to 68.061% when pulling **20ac80f7e81c1565ca1b46242bc8812e8c10025b on HeimingZ:IOTDB-2387** into **bcdab51721fb94db8e3506d1f4fb766a35972fd1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799#discussion_r783849462



##########
File path: docs/zh/UserGuide/Data-Concept/Time-Partition.md
##########
@@ -25,11 +25,13 @@
 
 时间分区按照时间分割数据，一个时间分区用于保存某个时间范围内的所有数据。时间分区编号使用自然数表示，0 表示 1970 年 1 月 1 日，每隔 partition_interval 秒后加一。数据通过计算 timestamp / partition_interval 得到自己所在的时间分区编号，主要配置项如下所示：
 
+注意：当前不建议开启此功能。 如果打开，请计算合适的 concurrent_writing_time_partition 和 wal_buffer_size

Review comment:
       ```suggestion
   注意：当前暂时不建议开启此功能。 如需打开，请计算合适的 concurrent_writing_time_partition 和 wal_buffer_size
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799#issuecomment-1011972528


   
   [![Coverage Status](https://coveralls.io/builds/45593379/badge)](https://coveralls.io/builds/45593379)
   
   Coverage increased (+0.02%) to 67.953% when pulling **cec428dd95f7fb55a639074c823c2015bdf41d47 on HeimingZ:IOTDB-2387** into **bcdab51721fb94db8e3506d1f4fb766a35972fd1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799#issuecomment-1011972528


   
   [![Coverage Status](https://coveralls.io/builds/45593189/badge)](https://coveralls.io/builds/45593189)
   
   Coverage increased (+0.01%) to 67.941% when pulling **cec428dd95f7fb55a639074c823c2015bdf41d47 on HeimingZ:IOTDB-2387** into **bcdab51721fb94db8e3506d1f4fb766a35972fd1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799#discussion_r783849962



##########
File path: docs/zh/UserGuide/Data-Concept/Time-Partition.md
##########
@@ -25,11 +25,13 @@
 
 时间分区按照时间分割数据，一个时间分区用于保存某个时间范围内的所有数据。时间分区编号使用自然数表示，0 表示 1970 年 1 月 1 日，每隔 partition_interval 秒后加一。数据通过计算 timestamp / partition_interval 得到自己所在的时间分区编号，主要配置项如下所示：
 
+注意：当前不建议开启此功能。 如果打开，请计算合适的 concurrent_writing_time_partition 和 wal_buffer_size

Review comment:
       Add a calculate method here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HeimingZ commented on a change in pull request #4799: [IOTDB-2387] Suggest disabling time partition function by default

Posted by GitBox <gi...@apache.org>.
HeimingZ commented on a change in pull request #4799:
URL: https://github.com/apache/iotdb/pull/4799#discussion_r783871903



##########
File path: docs/zh/UserGuide/Data-Concept/Time-Partition.md
##########
@@ -25,11 +25,13 @@
 
 时间分区按照时间分割数据，一个时间分区用于保存某个时间范围内的所有数据。时间分区编号使用自然数表示，0 表示 1970 年 1 月 1 日，每隔 partition_interval 秒后加一。数据通过计算 timestamp / partition_interval 得到自己所在的时间分区编号，主要配置项如下所示：
 
+注意：当前不建议开启此功能。 如果打开，请计算合适的 concurrent_writing_time_partition 和 wal_buffer_size

Review comment:
       Already added




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org