You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org> on 2005/12/06 14:26:09 UTC

[jira] Closed: (MYFACES-764) AddResource has changes that break custom classes and JSP pages using javascriptLocation

     [ http://issues.apache.org/jira/browse/MYFACES-764?page=all ]
     
Martin Marinschek closed MYFACES-764:
-------------------------------------

    Fix Version: Nightly
     Resolution: Fixed

Ok, I think this has been documented by Mathias in the meantime, and this jira-issue should be documentation as well, so I am closing this for now.

regards,

Martin

> AddResource has changes that break custom classes and JSP pages using javascriptLocation
> ----------------------------------------------------------------------------------------
>
>          Key: MYFACES-764
>          URL: http://issues.apache.org/jira/browse/MYFACES-764
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.2
>     Reporter: Simon Kitching
>     Assignee: Mathias Broekelmann
>      Fix For: Nightly

>
> R328404 was a significant rewrite of the AddResource class. The code is now much nicer.
> *However* the API of this class has changed in an incompatible manner, thus breaking every custom component that uses the AddResource.addJavaScriptToHeader method.
> In addition, it looks like the class now prefixes URLs with the context path by default [AddResource.getResourceUri calls ViewHandler.getResourceURL which prepends the context]. This change will break every user jsp file which specifies a javascriptLocation attribute on tags such as JSCookMenu, HtmlTree, HtmlAccordionPanel (and others) as formerly users *had* to include the context path, and now it is *always* prepended to the provided url.
> While I do like the new behaviour, and find it more useful than the old behaviour, I'm sure a little more attention to backwards compatibility would be appreciated by MyFaces users. And at the very least, I think backwards-incompatible changes such as this really should be clearly announced on the mail lists, and noted in the SVN commit message.
> I've been asked by Martin to create this JIRA entry to track this issue. See also: 
>    http://www.mail-archive.com/users%40myfaces.apache.org/msg11139.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira