You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/12 02:12:04 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #8817: [sip-15] Displaying endpoints for all start/end time ranges

john-bodley opened a new pull request #8817: [sip-15] Displaying endpoints for all start/end time ranges
URL: https://github.com/apache/incubator-superset/pull/8817
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR adds the SIP-15 endpoints to all time ranges which include a start and/or end as not just those containing a timestamp. This helps to provide more transparency. Note the conditional logic has mostly been reverted to what was changed [here](https://github.com/apache/incubator-superset/pull/8398/files).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   <img width="310" alt="Screen Shot 2019-12-12 at 3 03 20 PM" src="https://user-images.githubusercontent.com/4567245/70676620-a938f600-1cf1-11ea-91b7-43a2bda467a5.png">
   <img width="208" alt="Screen Shot 2019-12-12 at 3 03 31 PM" src="https://user-images.githubusercontent.com/4567245/70676621-a938f600-1cf1-11ea-9c2a-a33b1982f6b8.png">
   <img width="327" alt="Screen Shot 2019-12-12 at 3 03 44 PM" src="https://user-images.githubusercontent.com/4567245/70676622-a938f600-1cf1-11ea-8475-53b3ff88ab5c.png">
   <img width="116" alt="Screen Shot 2019-12-12 at 3 11 36 PM" src="https://user-images.githubusercontent.com/4567245/70676638-b6ee7b80-1cf1-11ea-88dc-5dbee1e4bb50.png">
   
   ### TEST PLAN
   
   CI and manual testing. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @etr2460 @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org