You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/10/31 17:48:13 UTC
Review Request 63447: Fixed bulleted list formatting.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63447/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Repository: mesos
Description
-------
Fixed the bulleted list formatting in the nested container
documentation. Markdown needs a blank like before lists,
otherwise it wraps the list up into the preceeding paragraph.
Diffs
-----
docs/nested-container-and-task-group.md 7f89c26adc0faa2759c06c47a92f6853634d5508
src/launcher/default_executor.cpp 306405291ba843941c351d6cde4cfa5c1352b8de
src/tests/default_executor_tests.cpp f485b613084331c18781c2f0070d049061179050
Diff: https://reviews.apache.org/r/63447/diff/1/
Testing
-------
Verified in middleman.
Thanks,
James Peach
Re: Review Request 63447: Fixed bulleted list formatting.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63447/#review189739
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Oct. 31, 2017, 10:48 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63447/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 10:48 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the bulleted list formatting in the nested container
> documentation. Markdown needs a blank like before lists,
> otherwise it wraps the list up into the preceeding paragraph.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 7f89c26adc0faa2759c06c47a92f6853634d5508
>
>
> Diff: https://reviews.apache.org/r/63447/diff/3/
>
>
> Testing
> -------
>
> Verified in middleman.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63447: Fixed bulleted list formatting.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63447/#review189777
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Failed command: `C:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63447
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63447/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (283 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/0
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (375 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/1
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (293 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/2
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (321 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (3262 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (141 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (379 ms total)
[----------] Global test environment tear-down
C:\DCOS\mesos\mesos\src\tests\environment.cpp(756): error: Failed
Tests completed with child processes remaining:
-+- 3116 000000D7452FE55C
--- 1132 000000D7452FE55C
[==========] 726 tests from 73 test cases ran. (387790 ms total)
[ PASSED ] 726 tests.
[ FAILED ] 0 tests, listed below:
0 FAILED TESTS
YOU HAVE 166 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63447/logs/mesos-tests-stderr.log):
```
I1101 02:38:20.263586 5896 containerizer.cpp:662] Recovering containerizer
I1101 02:38:20.270586 1544 provisioner.cpp:416] Provisioner recovery complete
I1101 02:38:20.271587 2500 slave.cpp:6340] Finished recovery
I1101 02:38:20.296593 5056 http.cpp:1185] HTTP GET for /slave(272)/monitor/statistics.json from 10.3.1.7:55574
I1101 02:38:20.296593 5056 http.cpp:976] Authorizing principal 'test-principal' to GET the '/monitor/statistics.json' endpoint
I1101 02:38:20.328589 1544 slave.cpp:875] Agent terminating
I1101 02:38:20.469597 5564 containerizer.cpp:301] Using isolation { windows/cpu, filesystem/windows, environment_secret }
I1101 02:38:20.471596 5564 provisioner.cpp:255] Using default backend 'copy'
I1101 02:38:20.498592 5564 cluster.cpp:448] Creating default 'local' authorizer
I1101 02:38:20.521592 5056 slave.cpp:254] Mesos agent started on (273)@10.3.1.7:54624
I1101 02:38:20.521592 5056 slave.cpp:255] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\dcnc8A\store\appc" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\dcnc8A\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\dcnc8A\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_reregistration_timeout="2secs" --execu
tor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\dcnc8A\fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\dcnc8A\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\DCOS\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="10ms" --resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --runtime_dir="C:\Users\mesos\AppData\Local\Temp\dcnc8A" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="false"
--work_dir="C:\Users\mesos\AppData\Local\Temp\bNi0ku" --zk_session_timeout="10secs"
I1101 02:38:20.556594 5056 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\dcnc8A\credential'
I1101 02:38:20.558591 5056 slave.cpp:287] Agent using credential for: test-principal
I1101 02:38:20.558591 5056 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\dcnc8A\http_credentials'
I1101 02:38:20.560591 5056 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly'
I1101 02:38:20.561591 5056 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readwrite'
I1101 02:38:20.573593 5056 slave.cpp:585] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I1101 02:38:20.590265 5056 slave.cpp:593] Agent attributes: [ ]
I1101 02:38:20.590265 5056 slave.cpp:602] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1101 02:38:20.590265 5648 status_update_manager.cpp:177] Pausing sending status updates
I1101 02:38:20.600288 5896 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\bNi0ku\meta'
I1101 02:38:20.601279 5648 status_update_manager.cpp:203] Recovering status update manager
I1101 02:38:20.602279 2500 containerizer.cpp:662] Recovering containerizer
I1101 02:38:20.609273 5056 provisioner.cpp:416] Provisioner recovery complete
I1101 02:38:20.611279 4604 slave.cpp:6340] Finished recovery
I1101 02:38:20.629272 4604 http.cpp:1185] HTTP GET for /slave(273)/containers from 10.3.1.7:55575
I1101 02:38:20.630272 4604 http.cpp:976] Authorizing principal 'test-principal' to GET the '/containers' endpoint
I1101 02:38:20.667274 6028 slave.cpp:875] Agent terminating
I1101 02:38:21.458456 5260 process.cpp:1067] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Oct. 31, 2017, 5:48 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63447/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 5:48 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the bulleted list formatting in the nested container
> documentation. Markdown needs a blank like before lists,
> otherwise it wraps the list up into the preceeding paragraph.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 7f89c26adc0faa2759c06c47a92f6853634d5508
>
>
> Diff: https://reviews.apache.org/r/63447/diff/3/
>
>
> Testing
> -------
>
> Verified in middleman.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63447: Fixed bulleted list formatting.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63447/#review189754
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63447]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 31, 2017, 5:48 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63447/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 5:48 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the bulleted list formatting in the nested container
> documentation. Markdown needs a blank like before lists,
> otherwise it wraps the list up into the preceeding paragraph.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 7f89c26adc0faa2759c06c47a92f6853634d5508
>
>
> Diff: https://reviews.apache.org/r/63447/diff/3/
>
>
> Testing
> -------
>
> Verified in middleman.
>
>
> Thanks,
>
> James Peach
>
>