You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/03/07 06:55:34 UTC
[Impala-ASF-CR] PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21114
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
......................................................................
PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
This modifies the cup-maven-plugin to only regenerate the
CUP-generated files if the .cup file is newer than the
generated code. This substantially speeds up an incremental
compilation of the fe directory. On my machine, running
'mvn install -DskipTests' goes from around 10 seconds to
about 2 seconds.
Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
---
M java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/21114/1
--
To view, visit http://gerrit.cloudera.org:8080/21114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
Gerrit-Change-Number: 21114
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java
File java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java:
http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@437
PS1, Line 437: boolean generatedCodeOutOfDate = false;
> Do we need to worry about externalTables?
Good point, that is something I'm missing. We want to look at any .dat files and make sure they are not out of date. They are generated at the same time as the other files, but for completeness it is still a good idea.
--
To view, visit http://gerrit.cloudera.org:8080/21114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
Gerrit-Change-Number: 21114
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 17:36:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/15434/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
Gerrit-Change-Number: 21114
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 07:21:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java
File java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java:
http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@437
PS1, Line 437: boolean generatedCodeOutOfDate = false;
Do we need to worry about externalTables?
--
To view, visit http://gerrit.cloudera.org:8080/21114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
Gerrit-Change-Number: 21114
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 17:29:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java
File java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java:
http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@437
PS1, Line 437: boolean generatedCodeOutOfDate = false;
> Good point, that is something I'm missing. We want to look at any .dat file
Would you like me to try and finish that? I've been recompiling Java a lot recently and this would be helpful.
--
To view, visit http://gerrit.cloudera.org:8080/21114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
Gerrit-Change-Number: 21114
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 19:43:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin
......................................................................
Abandoned
Switched to using CMake
--
To view, visit http://gerrit.cloudera.org:8080/21114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643
Gerrit-Change-Number: 21114
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>