You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Stefania (JIRA)" <ji...@apache.org> on 2015/03/31 11:41:53 UTC

[jira] [Commented] (CASSANDRA-8893) RandomAccessReader should share its FileChannel with all instances (via SegmentedFile)

    [ https://issues.apache.org/jira/browse/CASSANDRA-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388318#comment-14388318 ] 

Stefania commented on CASSANDRA-8893:
-------------------------------------

[~benedict] can you confirm that the changes required are:

1. Use one single FileChannel instance for all RAR instances created by the same SegmentedFile instance, by passing the file channel in the constructor
2. Make sure the operations on the file channel are thread safe (e.g. by specifying the position in all operations since the file channel is then thread safe)

Correct?

> RandomAccessReader should share its FileChannel with all instances (via SegmentedFile)
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8893
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8893
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Stefania
>             Fix For: 3.0
>
>
> There's no good reason to open a FileChannel for each \(Compressed\)\?RandomAccessReader, and this would simplify RandomAccessReader to just a thin wrapper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)