You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2026/09/08 10:19:58 UTC

[PR] GH-51232: [CI] Update comment bot to prevent people being assigned things via "take" unless unassigned [arrow]

thisisnic opened a new pull request, #51233:
URL: https://github.com/apache/arrow/pull/51233

   ### Rationale for this change
   
   Non-committers could assign themselves issues already assigned to people
   
   ### What changes are included in this PR?
   
   Only let "take" assign issues if the issue isn't assigned
   
   ### Are these changes tested?
   
   No
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51232: [CI] Remove the "take" comment bot for self-assigning issues [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #51233:
URL: https://github.com/apache/arrow/pull/51233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-51232: [CI] Update comment bot to prevent people being assigned things via "take" unless unassigned [arrow]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #51233:
URL: https://github.com/apache/arrow/pull/51233#discussion_r3956842219


##########
.github/workflows/comment_bot.yml:
##########
@@ -61,7 +61,9 @@ jobs:
     name: "Assign issue"
     permissions:
       issues: write
-    if: github.event.comment.body == 'take'
+    if: |
+      github.event.comment.body == 'take' &&
+      github.event.issue.assignee == null

Review Comment:
   The workflow triggers on `issue_comment`, which fires for both issues and pull requests. As written, a `take` comment on an unassigned PR would also assign the PR to the commenter, which doesn’t match the intended “issue-only” behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org