You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/04 09:28:28 UTC

[GitHub] [rocketmq] guyinyou opened a new pull request #3216: [ISSUE #3215] polish litePullConsumer seek logic

guyinyou opened a new pull request #3216:
URL: https://github.com/apache/rocketmq/pull/3216


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   #3215 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] guyinyou commented on pull request #3216: [ISSUE #3215] polish litePullConsumer seek logic

Posted by GitBox <gi...@apache.org>.
guyinyou commented on pull request #3216:
URL: https://github.com/apache/rocketmq/pull/3216#issuecomment-903399197


   Sorry forgotten!
   
   before ≈ 19s
   ![图片 1](https://user-images.githubusercontent.com/36399867/130382595-d2066e04-f409-49b7-87d8-ea74c44934d0.png)
   
   after < 1s
   ![图片 2](https://user-images.githubusercontent.com/36399867/130382615-474a5c88-7499-4d62-a2ca-3d1c2463c527.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3216: [ISSUE #3215] polish litePullConsumer seek logic

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3216:
URL: https://github.com/apache/rocketmq/pull/3216#issuecomment-892524231


   
   [![Coverage Status](https://coveralls.io/builds/41893466/badge)](https://coveralls.io/builds/41893466)
   
   Coverage increased (+0.07%) to 54.16% when pulling **e4d40b927e5994eeb79d0698e7c76315e990aecf on guyinyou:apache-dev** into **44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3216: [ISSUE #3215] polish litePullConsumer seek logic

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3216:
URL: https://github.com/apache/rocketmq/pull/3216#issuecomment-892524231


   
   [![Coverage Status](https://coveralls.io/builds/41893466/badge)](https://coveralls.io/builds/41893466)
   
   Coverage increased (+0.07%) to 54.16% when pulling **e4d40b927e5994eeb79d0698e7c76315e990aecf on guyinyou:apache-dev** into **44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] guyinyou closed pull request #3216: [ISSUE #3215] polish litePullConsumer seek logic

Posted by GitBox <gi...@apache.org>.
guyinyou closed pull request #3216:
URL: https://github.com/apache/rocketmq/pull/3216


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org