You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by "Craig Marvelley (JIRA)" <ji...@apache.org> on 2010/05/26 18:11:37 UTC
[jira] Created: (LOG4PHP-118) Additivity cannot be disabled through
log4php.properties ini file.
Additivity cannot be disabled through log4php.properties ini file.
------------------------------------------------------------------
Key: LOG4PHP-118
URL: https://issues.apache.org/jira/browse/LOG4PHP-118
Project: Log4php
Issue Type: Bug
Components: Code
Affects Versions: 2.0
Environment: PHP 5.3 Windows
Reporter: Craig Marvelley
The code in LoggerConfiguratorIni that parses the additivity setting does a check on the value of the config option to see if it is empty() before it applies it - since this option has previously been parsed by parse_ini_file any falsey values will not pass this check, so additivity cannot be disabled.
I've attached a patch which removes the check. Additivity is still on by default should the option not be set, so everything seems to work as normal otherwise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LOG4PHP-118) Additivity cannot be disabled through
log4php.properties ini file.
Posted by "Craig Marvelley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Marvelley updated LOG4PHP-118:
------------------------------------
Attachment: additivity_patch.patch
> Additivity cannot be disabled through log4php.properties ini file.
> ------------------------------------------------------------------
>
> Key: LOG4PHP-118
> URL: https://issues.apache.org/jira/browse/LOG4PHP-118
> Project: Log4php
> Issue Type: Bug
> Components: Code
> Affects Versions: 2.0
> Environment: PHP 5.3 Windows
> Reporter: Craig Marvelley
> Attachments: additivity_patch.patch
>
>
> The code in LoggerConfiguratorIni that parses the additivity setting does a check on the value of the config option to see if it is empty() before it applies it - since this option has previously been parsed by parse_ini_file any falsey values will not pass this check, so additivity cannot be disabled.
> I've attached a patch which removes the check. Additivity is still on by default should the option not be set, so everything seems to work as normal otherwise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.