You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2015/07/31 22:35:39 UTC
[1/2] trafficserver git commit: Revert "TS-3810 traffic_manager leaks
that thread stack, make sure to detach the threads"
Repository: trafficserver
Updated Branches:
refs/heads/master b5c7dbb8a -> a532d6d9d
Revert "TS-3810 traffic_manager leaks that thread stack, make sure to detach the threads"
This reverts commit b5c7dbb8a9265e83742a0c56744c9fa4a298c7f0.
jpeach says to pass the detach=1 to ink_thread_create.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/9180ed6c
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/9180ed6c
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/9180ed6c
Branch: refs/heads/master
Commit: 9180ed6c514b586249c21bacc33e12e84e6301fc
Parents: b5c7dbb
Author: Leif Hedstrom <zw...@apache.org>
Authored: Fri Jul 31 14:33:23 2015 -0600
Committer: Leif Hedstrom <zw...@apache.org>
Committed: Fri Jul 31 14:33:23 2015 -0600
----------------------------------------------------------------------
cmd/traffic_manager/MgmtHandlers.cc | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/9180ed6c/cmd/traffic_manager/MgmtHandlers.cc
----------------------------------------------------------------------
diff --git a/cmd/traffic_manager/MgmtHandlers.cc b/cmd/traffic_manager/MgmtHandlers.cc
index 0569d2b..a7f44ce 100644
--- a/cmd/traffic_manager/MgmtHandlers.cc
+++ b/cmd/traffic_manager/MgmtHandlers.cc
@@ -258,8 +258,6 @@ mgmt_synthetic_main(void *)
if (thrId <= 0) {
mgmt_log(stderr, "[SyntheticHealthServer] Failed to create worker thread");
- } else {
- pthread_detach(thrId); // We don't care to join this sucker
}
}
}
[2/2] trafficserver git commit: TS-3810 traffic_manager leaks that
thread stack, make sure to detach the threads
Posted by zw...@apache.org.
TS-3810 traffic_manager leaks that thread stack, make sure to detach the threads
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a532d6d9
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a532d6d9
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a532d6d9
Branch: refs/heads/master
Commit: a532d6d9de75c1802700e1e18c3f27742cc65e87
Parents: 9180ed6
Author: Leif Hedstrom <zw...@apache.org>
Authored: Fri Jul 31 14:35:35 2015 -0600
Committer: Leif Hedstrom <zw...@apache.org>
Committed: Fri Jul 31 14:35:35 2015 -0600
----------------------------------------------------------------------
cmd/traffic_manager/MgmtHandlers.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a532d6d9/cmd/traffic_manager/MgmtHandlers.cc
----------------------------------------------------------------------
diff --git a/cmd/traffic_manager/MgmtHandlers.cc b/cmd/traffic_manager/MgmtHandlers.cc
index a7f44ce..5e974ef 100644
--- a/cmd/traffic_manager/MgmtHandlers.cc
+++ b/cmd/traffic_manager/MgmtHandlers.cc
@@ -254,7 +254,7 @@ mgmt_synthetic_main(void *)
mgmt_log(stderr, "[SyntheticHealthServer] Connect by disallowed client %s, closing\n", inet_ntoa(clientInfo.sin_addr));
close_socket(clientFD);
} else {
- ink_thread thrId = ink_thread_create(synthetic_thread, (void *)&clientFD);
+ ink_thread thrId = ink_thread_create(synthetic_thread, (void *)&clientFD, 1);
if (thrId <= 0) {
mgmt_log(stderr, "[SyntheticHealthServer] Failed to create worker thread");