You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/05/10 03:42:45 UTC
[jira] Created: (CASSANDRA-159) avoid repetetive sorting in
CFS.getColumnFamilyFromDisk
avoid repetetive sorting in CFS.getColumnFamilyFromDisk
-------------------------------------------------------
Key: CASSANDRA-159
URL: https://issues.apache.org/jira/browse/CASSANDRA-159
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Fix For: 0.4
getColumnFamilyFromDisk starts out with
List<String> files = new ArrayList<String>();
lock_.readLock().lock();
try
{
files.addAll(ssTables_);
Collections.sort(files, new FileNameComparator(FileNameComparator.Descending));
}
finally
{
lock_.readLock().unlock();
}
this is silly, we should really keep the list sorted instead of re-sorting for *each* *read*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-159) avoid repetetive sorting in
CFS.getColumnFamilyFromDisk
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-159:
-------------------------------------
Attachment: 0002-CASSANDRA-159-fix-race-condition-between-when-memtable.txt
0001-extract-tests-that-could-conflict-with-each-other-to-a.txt
> avoid repetetive sorting in CFS.getColumnFamilyFromDisk
> -------------------------------------------------------
>
> Key: CASSANDRA-159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-159
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> getColumnFamilyFromDisk starts out with
> List<String> files = new ArrayList<String>();
> lock_.readLock().lock();
> try
> {
> files.addAll(ssTables_);
> Collections.sort(files, new FileNameComparator(FileNameComparator.Descending));
> }
> finally
> {
> lock_.readLock().unlock();
> }
> this is silly, we should really keep the list sorted instead of re-sorting for *each* *read*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-159) avoid repetetive sorting in
CFS.getColumnFamilyFromDisk
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-159.
--------------------------------------
Resolution: Fixed
Assignee: Jonathan Ellis
fixed by patch for CASSANDRA-161
> avoid repetetive sorting in CFS.getColumnFamilyFromDisk
> -------------------------------------------------------
>
> Key: CASSANDRA-159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-159
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
>
> getColumnFamilyFromDisk starts out with
> List<String> files = new ArrayList<String>();
> lock_.readLock().lock();
> try
> {
> files.addAll(ssTables_);
> Collections.sort(files, new FileNameComparator(FileNameComparator.Descending));
> }
> finally
> {
> lock_.readLock().unlock();
> }
> this is silly, we should really keep the list sorted instead of re-sorting for *each* *read*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-159) avoid repetetive sorting in
CFS.getColumnFamilyFromDisk
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-159:
-------------------------------------
Attachment: (was: 0001-extract-tests-that-could-conflict-with-each-other-to-a.txt)
> avoid repetetive sorting in CFS.getColumnFamilyFromDisk
> -------------------------------------------------------
>
> Key: CASSANDRA-159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-159
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> getColumnFamilyFromDisk starts out with
> List<String> files = new ArrayList<String>();
> lock_.readLock().lock();
> try
> {
> files.addAll(ssTables_);
> Collections.sort(files, new FileNameComparator(FileNameComparator.Descending));
> }
> finally
> {
> lock_.readLock().unlock();
> }
> this is silly, we should really keep the list sorted instead of re-sorting for *each* *read*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-159) avoid repetetive sorting in
CFS.getColumnFamilyFromDisk
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-159:
-------------------------------------
Attachment: (was: 0002-CASSANDRA-159-fix-race-condition-between-when-memtable.txt)
> avoid repetetive sorting in CFS.getColumnFamilyFromDisk
> -------------------------------------------------------
>
> Key: CASSANDRA-159
> URL: https://issues.apache.org/jira/browse/CASSANDRA-159
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> getColumnFamilyFromDisk starts out with
> List<String> files = new ArrayList<String>();
> lock_.readLock().lock();
> try
> {
> files.addAll(ssTables_);
> Collections.sort(files, new FileNameComparator(FileNameComparator.Descending));
> }
> finally
> {
> lock_.readLock().unlock();
> }
> this is silly, we should really keep the list sorted instead of re-sorting for *each* *read*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.