You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/12 02:02:58 UTC

[GitHub] [samza] Sanil15 opened a new pull request #1314: SAMZA-2484: Fix flaky tests for Container Placements

Sanil15 opened a new pull request #1314: SAMZA-2484: Fix flaky tests for Container Placements
URL: https://github.com/apache/samza/pull/1314
 
 
   **Symptom:**
   Noticed a few runs being flaky with:
   
   org.apache.samza.clustermanager.TestContainerPlacementActions > testAlwaysMoveToAnyHostForHostAffinityDisabled FAILED
       java.lang.AssertionError: expected:<IN_PROGRESS> but was:<SUCCEEDED>
           at org.junit.Assert.fail(Assert.java:88)
           at org.junit.Assert.failNotEquals(Assert.java:834)
           at org.junit.Assert.assertEquals(Assert.java:118)
           at org.junit.Assert.assertEquals(Assert.java:144)
           at org.apache.samza.clustermanager.TestContainerPlacementActions.testAlwaysMoveToAnyHostForHostAffinityDisabled(TestContainerPlacementActions.java:746)
    
   **Cause:**
   A race between main thread expects to read a success message from metastore and am-rm thread to write a success messages  
   
   Changes:
   Make the main thread busy loop on metastore success message, since a semaphore is hard to inject
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] rmatharu commented on issue #1314: SAMZA-2484: Fix flaky tests for Container Placements

Posted by GitBox <gi...@apache.org>.
rmatharu commented on issue #1314: SAMZA-2484: Fix flaky tests for Container Placements
URL: https://github.com/apache/samza/pull/1314#issuecomment-598828098
 
 
   Is there a way to write such tests based on invariants, so that they dont rely on thread-sleeps and fail in case of scheduling delays?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [samza] mynameborat merged pull request #1314: SAMZA-2484: Fix flaky tests for Container Placements

Posted by GitBox <gi...@apache.org>.
mynameborat merged pull request #1314: SAMZA-2484: Fix flaky tests for Container Placements
URL: https://github.com/apache/samza/pull/1314
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services