You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/04 11:42:59 UTC
[GitHub] [cloudstack] ravening opened a new pull request #5664: alert: Send alert for ha'ed vm's
ravening opened a new pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664
### Description
When ha is performed on vm's send the alert for it so that
its for admins to know which vm's got ha'ed else its time
consuming to get those details from logs
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008716678
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068741705
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1033776872
> Ping @ravening
@nvazquez done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1034091259
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 2545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1043749740
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-972735907
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068720630
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1069209412
<b>Trillian test result (tid-3628)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32812 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5664-t3628-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1034066749
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007877607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008917166
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068720945
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-972637634
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#discussion_r776785893
##########
File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java
##########
@@ -608,7 +608,9 @@ protected Long restart(final HaWorkVO work) {
VMInstanceVO started = _instanceDao.findById(vm.getId());
if (started != null && started.getState() == VirtualMachine.State.Running) {
+ String message = String.format("HA on VM: %s", started.getHostName());
Review comment:
I like the idea of enhancing the alerts.
What do you think of changing from `Ha on VM: VM Name` to `Ha Starting VM: VM Name (i-2-13477-VM)`.
Thus, making it `String.format("HA on VM: %s (%s)", started.getHostName(), started.getInstanceName());`.
##########
File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java
##########
@@ -608,7 +608,9 @@ protected Long restart(final HaWorkVO work) {
VMInstanceVO started = _instanceDao.findById(vm.getId());
if (started != null && started.getState() == VirtualMachine.State.Running) {
+ String message = String.format("HA on VM: %s", started.getHostName());
s_logger.info("VM is now restarted: " + vmId + " on " + started.getHostId());
Review comment:
Taking the opportunity, what do you think of enhancing also the INFO log message?
As a suggestion, it could be logged something as the following:
```
HA is now restarting VM instance {id: "123", name: "VM Name", uuid: "1234.....abc", type="User"} on Host [{id: "1", name: "host.name", uuid: "ABC...123", type="Routing"}]
```
With the following code changes:
```suggestion
HostVO hostVmHasStarted = _hostDao.findById(started.getHostId());
s_logger.info(String.format("HA is now restarting %s on %s", started, hostVmHasStarted));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008880417
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1009650135
HI @ravening Can you address outstanding comments. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1034067221
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008638371
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-961025109
> > clgtm, but would the subject exactly the same as the content be helpful? can we add more info to the mail content?
>
> @DaanHoogland if you have any content then let me know.. i can add that
source and target host? time down? time up? down time duration?
just suggestions @ravening . What would you need to know as operator. As said, clgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-960812928
> clgtm, but would the subject exactly the same as the content be helpful? can we add more info to the mail content?
@DaanHoogland if you have any content then let me know.. i can add that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud removed a comment on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
rohityadavcloud removed a comment on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007877411
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1002974044
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068686964
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-972637934
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007877607
@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007899528
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1009455140
<b>Trillian test result (tid-2845)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31418 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5664-t2845-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1002974817
@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1003012891
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008605940
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008715992
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#discussion_r781802105
##########
File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java
##########
@@ -608,7 +608,9 @@ protected Long restart(final HaWorkVO work) {
VMInstanceVO started = _instanceDao.findById(vm.getId());
if (started != null && started.getState() == VirtualMachine.State.Running) {
+ String message = String.format("HA on VM: %s", started.getHostName());
Review comment:
@ravening Do you want to add instance name to the alert message (as advised)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068738204
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007877411
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1043748507
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068687350
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068742295
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-976530709
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008796906
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 2157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008605940
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007877607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1043799111
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1068719977
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1030739212
Ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-976417867
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-976417355
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1007877411
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008914204
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5664: alert: Send alert for ha'ed vm's
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5664:
URL: https://github.com/apache/cloudstack/pull/5664#issuecomment-1008606070
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org