You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "David Latorre (JIRA)" <ji...@apache.org> on 2008/08/18 11:13:44 UTC

[jira] Created: (FTPSERVER-162) DbUserManager's createConnection visibility

DbUserManager's createConnection  visibility
--------------------------------------------

                 Key: FTPSERVER-162
                 URL: https://issues.apache.org/jira/browse/FTPSERVER-162
             Project: FtpServer
          Issue Type: Improvement
    Affects Versions: 1.0-M3
            Reporter: David Latorre
            Priority: Minor


If we need to extend DbUserManager we find that  the method createConnection is private :

private synchronized Connection createConnection() throws SQLException {

So we have to implement our own method to create a connection and we cannot use "cachedConnection" which is also a private member.

My suggestion is that createConnection be made protected so inheriting classes can use it.

  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FTPSERVER-162) DbUserManager's createConnection visibility

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson closed FTPSERVER-162.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0-M3
         Assignee: Niklas Gustavsson

Makes sense, commited fix.

svn commit "/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java" -m "Make createConnection available to subclasses (FTPSERVER-162)" --username "ngn"
	M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java
	  Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java
Committed revision 686706

> DbUserManager's createConnection  visibility
> --------------------------------------------
>
>                 Key: FTPSERVER-162
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-162
>             Project: FtpServer
>          Issue Type: Improvement
>    Affects Versions: 1.0-M3
>            Reporter: David Latorre
>            Assignee: Niklas Gustavsson
>            Priority: Minor
>             Fix For: 1.0-M3
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> If we need to extend DbUserManager we find that  the method createConnection is private :
> private synchronized Connection createConnection() throws SQLException {
> So we have to implement our own method to create a connection and we cannot use "cachedConnection" which is also a private member.
> My suggestion is that createConnection be made protected so inheriting classes can use it.
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.