[GitHub] oschaaf commented on issue #1727: Fix failing `devel/build_release_tarball.sh`

[GitBox <gi...@apache.org>]

oschaaf commented on issue #1727: Fix failing `devel/build_release_tarball.sh`
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1727#issuecomment-360391642
 
 
   @morlovich -D for system zlib was missing, correct:
   
   ```
   130 oschaaf@dev:/tmp/tmp.EQF43g15e6/modpagespeed-1.14.0.0/src? make V=1  pagespeed_automatic_test  | grep -i \\-D
     g++ '-D_GLIBCXX_USE_CXX11_ABI=0' '-DV8_DEPRECATION_WARNINGS' '-DBLINK_SCALE_FILTERS_AT_RECORD_TIME' '-D_FILE_OFFSET_BITS=64' '-DPAGESPEED_SUPPORT_POSIX_SHARED_MEM' '-DGTEST_HAS_RTTI=1' '-DCHROMIUM_BUILD' '-DTOOLKIT_VIEWS=1' '-DUI_COMPOSITOR_IMAGE_TRANSPORT' '-DUSE_AURA=1' '-DUSE_CAIRO=1' '-DUSE_GLIB=1' '-DUSE_DEFAULT_RENDER_THEME=1' '-DUSE_LIBJPEG_TURBO=1' '-DUSE_NSS=1' '-DUSE_X11=1' '-DUSE_CLIPBOARD_AURAX11=1' '-DENABLE_ONE_CLICK_SIGNIN' '-DUSE_XI2_MT=2' '-DENABLE_REMOTING=1' '-DENABLE_WEBRTC=1' '-DENABLE_PEPPER_CDMS' '-DENABLE_CONFIGURATION_POLICY' '-DENABLE_INPUT_SPEECH' '-DENABLE_NOTIFICATIONS' '-DENABLE_NEW_GAMEPAD_API=1' '-DUSE_UDEV' '-DENABLE_EGLIMAGE=1' '-DENABLE_TASK_MANAGER=1' '-DENABLE_EXTENSIONS=1' '-DENABLE_PLUGIN_INSTALLATION=1' '-DENABLE_PLUGINS=1' '-DENABLE_SESSION_SERVICE=1' '-DENABLE_THEMES=1' '-DENABLE_AUTOFILL_DIALOG=1' '-DENABLE_BACKGROUND=1' '-DENABLE_AUTOMATION=1' '-DENABLE_GOOGLE_NOW=1' '-DCLD_VERSION=2' '-DENABLE_FULL_PRINTING=1' '-DENABLE_PRINTING=1' '-
 DENABLE_SPELLCHECK=1' '-DENABLE_CAPTIVE_PORTAL_DETECTION=1' '-DENABLE_APP_LIST=1' '-DENABLE_SETTINGS_APP=1' '-DENABLE_MANAGED_USERS=1' '-DENABLE_MDNS=1' '-DGTEST_HAS_POSIX_RE=0' '-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER' '-DUNIT_TEST' '-D_LARGEFILE64_SOURCE' '-DHAVE_CONFIG_H' '-DLINUX=2' '-D_REENTRANT' '-D_GNU_SOURCE' '-DUSE_SYSTEM_LIBPNG' '-DDBG=1' '-DPNG_SKIP_SETJMP_CHECK' '-DDYNAMIC_ANNOTATIONS_ENABLED=1' '-DWTF_USE_DYNAMIC_ANNOTATIONS=1' '-D_DEBUG' -Ithird_party/chromium/src -Ithird_party/protobuf/src -Iout/Debug/obj/gen/protoc_out/instaweb -I. -Ithird_party/css_parser/src -Ithird_party/libwebp/src -Ithird_party/google-sparsehash/gen/arch/linux/x64/include -Ithird_party/google-sparsehash/src/src -Iurl -Ithird_party/protobuf/src/src -Ithird_party/re2/src -Ithird_party/grpc/src/include -Itesting/gtest/include -Ithird_party/protobuf -Itesting/gmock/include -I/usr/include/apr-1.0 -I/usr/include/apr-1.0  -fstack-protector --param=ssp-buffer-size=4 -pthread -fno-exceptions -fno-strict-
 aliasing -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -fexceptions -fasynchronous-unwind-tables -D_FORTIFY_SOURCE=2 -I/usr/include/libpng12 -Wno-format -Wno-unused-result -O0 -g -funwind-tables -std=gnu++0x -fno-threadsafe-statics -fvisibility-inlines-hidden -frtti -D_FORTIFY_SOURCE=2 -Wno-deprecated -MMD -MF out/Debug/.deps/out/Debug/obj.target/pagespeed_automatic_test/pagespeed/kernel/image/png_optimizer_test.o.d.raw  -c -o out/Debug/obj.target/pagespeed_automatic_test/pagespeed/kernel/image/png_optimizer_test.o pagespeed/kernel/image/png_optimizer_test.cc
   pagespeed/kernel/image/png_optimizer_test.cc:45:39: fatal error: third_party/zlib/src/zlib.h: No such file or directory
    #include "third_party/zlib/src/zlib.h"
                                          ^
   compilation terminated.
   make: *** [out/Debug/obj.target/pagespeed_automatic_test/pagespeed/kernel/image/png_optimizer_test.o] Error 1
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services