You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:09:33 UTC

[GitHub] [flink] MartijnVisser opened a new pull request, #21047: [FLINK-29623][Metrics][Prometheus] Update Prometheus Java Client to 0.16.0

MartijnVisser opened a new pull request, #21047:
URL: https://github.com/apache/flink/pull/21047

   ## What is the purpose of the change
   
   * Flink uses an old and no longer supported version of io.prometheus:simpleclient. We should upgrade to the latest version
   
   ## Brief change log
   
   * Updated POM and NOTICE files
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21047: [FLINK-29623][Metrics][Prometheus] Update Prometheus Java Client to 0.16.0

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21047:
URL: https://github.com/apache/flink/pull/21047#issuecomment-1277296241

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "501fef3138ba445d1e16af0e6e94bb0dfdee8b81",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "501fef3138ba445d1e16af0e6e94bb0dfdee8b81",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 501fef3138ba445d1e16af0e6e94bb0dfdee8b81 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser closed pull request #21047: [FLINK-29623][Metrics][Prometheus] Update Prometheus Java Client to 0.16.0

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #21047: [FLINK-29623][Metrics][Prometheus] Update Prometheus Java Client to 0.16.0
URL: https://github.com/apache/flink/pull/21047


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21047: [FLINK-29623][Metrics][Prometheus] Update Prometheus Java Client to 0.16.0

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21047:
URL: https://github.com/apache/flink/pull/21047#issuecomment-1277572072

   This is at this time intentional; last time I looked into it I found that they changed the data model and we should look at the ramifications of that first before bumping anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21047: [FLINK-29623][Metrics][Prometheus] Update Prometheus Java Client to 0.16.0

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21047:
URL: https://github.com/apache/flink/pull/21047#issuecomment-1277688080

   > last time I looked into it I found that they changed the data model and we should look at the ramifications of that first before bumping anything.
   
   They've made such a change in their 0.10 version:
   
   > [CHANGE] Switch data model to OpenMetrics. Primarily this means that _total if present is stripped from the metric name of counters, and _total is now always a suffix on the sample value. This means that all Counter samples now have a _total suffix (https://github.com/prometheus/client_java/pull/615)
   > [CHANGE] The io.prometheus.client.Collector.Type enum' value UNTYPED renamed to UNKNOWN (https://github.com/prometheus/client_java/pull/615)
   
   We should actually check if there are proper tests for this too. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org