You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/06/10 12:22:19 UTC
[GitHub] [orc] igaztanaga opened a new pull request #514: Initialize "next_in" before calling DeflateInit2
igaztanaga opened a new pull request #514:
URL: https://github.com/apache/orc/pull/514
According to zlib documentation of DeflateInit2:
_"This is another version of deflateInit with more compression options. The fields **next_in**, zalloc, zfree and opaque must be initialized before by the caller."_
In an alpine docker DeflateInit2 was returning an error that seems to be solved with the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #514: ORC-659: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-671723913
Welcome, @igaztanaga . I added to the Apache ORC contributor group and assigned ORC-659 to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #514: ORC-659: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-672158127
This is now merged to `branch-1.6` and `branch-1.5` for next 1.6.4 and 1.5.11 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #514: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-670975313
Hi, @igaztanaga .
Could you describe how to reproduce the error?
> In an alpine docker DeflateInit2 was returning an error that seems to be solved with the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #514: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-671630927
Gentle ping, @igaztanaga ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #514: ORC-659: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #514:
URL: https://github.com/apache/orc/pull/514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #514: ORC-659: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-672157771
Thank you for replying, @igaztanaga . I merged it because I agree with you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #514: ORC-659: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-671723112
+1, LGTM. Thank you, @igaztanaga .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] igaztanaga commented on pull request #514: ORC-659: Initialize "next_in" before calling DeflateInit2
Posted by GitBox <gi...@apache.org>.
igaztanaga commented on pull request #514:
URL: https://github.com/apache/orc/pull/514#issuecomment-671827576
Sorry, somehow I overlooked your notification 3 days ago. Sometimes the init function returned error before the change, but I'm not sure if that was the only reason. Since the documentation explicitly stated that next_in should be initialized before calling DeflateInit2, we think the error was, in part, caused by a uninitialized value bug. Thanks for merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org