[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7290: [fix](select join) Make selected slotRef nullable when slotRef is from nullable tuple in outer join sql block

[GitBox <gi...@apache.org>]

caiconghui commented on a change in pull request #7290:
URL: https://github.com/apache/incubator-doris/pull/7290#discussion_r762775165



##########
File path: be/src/exprs/aggregate_functions.cpp
##########
@@ -838,7 +838,6 @@ void AggregateFunctions::string_concat_update(FunctionContext* ctx, const String
     if (result->is_null || !result->ptr) {
         // Header of the intermediate state holds the length of the first separator.
         const auto header_len = sizeof(StringConcatHeader);
-        DCHECK(header_len == sizeof(sep->len));

Review comment:
       header_len is const value now, but sep len can be various




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org