You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/07 09:26:19 UTC
[GitHub] [tvm] Mousius opened a new pull request #9218: [TVMC] Compose target options from target registry
Mousius opened a new pull request #9218:
URL: https://github.com/apache/tvm/pull/9218
[The RFC for this is still under discussion](https://github.com/apache/tvm-rfcs/pull/28), but doing this before splitting the registries makes the most sense. This enables the `tvmc` driver to re-combobulate Target options from arguments:
```
tvmc --target=llvm \
--target-llvm-mcpu=cortex-m3
```
This rolls in https://github.com/apache/tvm/pull/9206 so you may want to just look at the second commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9218:
URL: https://github.com/apache/tvm/pull/9218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9218:
URL: https://github.com/apache/tvm/pull/9218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #9218:
URL: https://github.com/apache/tvm/pull/9218#discussion_r727534142
##########
File path: python/tvm/driver/tvmc/target.py
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Yip, I didn't realise `test_common.py` matched with `common.py`, so there'll be another PR at some point to split out the mixed set of things in `common.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #9218:
URL: https://github.com/apache/tvm/pull/9218#issuecomment-941858425
Thanks @Mousius @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #9218:
URL: https://github.com/apache/tvm/pull/9218#issuecomment-941858425
Thanks @Mousius @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #9218:
URL: https://github.com/apache/tvm/pull/9218#discussion_r727372392
##########
File path: python/tvm/driver/tvmc/target.py
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
should target_from_cli move here?
##########
File path: python/tvm/driver/tvmc/target.py
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+This file contains functions for processing target inputs for the TVMC CLI
+"""
+
+from tvm.target import Target
+
+# We can't tell the type inside an Array but all current options are strings so
+# it can default to that. Bool is used alongside Integer but aren't distinguished
+# between as both are represented by IntImm
+INTERNAL_TO_NATIVE_TYPE = {"runtime.String": str, "IntImm": int, "Array": str}
Review comment:
this is kind of unfortunate but i see there isn't really much way around it right now without a very large refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #9218:
URL: https://github.com/apache/tvm/pull/9218#discussion_r727372392
##########
File path: python/tvm/driver/tvmc/target.py
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
should target_from_cli move here?
##########
File path: python/tvm/driver/tvmc/target.py
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+This file contains functions for processing target inputs for the TVMC CLI
+"""
+
+from tvm.target import Target
+
+# We can't tell the type inside an Array but all current options are strings so
+# it can default to that. Bool is used alongside Integer but aren't distinguished
+# between as both are represented by IntImm
+INTERNAL_TO_NATIVE_TYPE = {"runtime.String": str, "IntImm": int, "Array": str}
Review comment:
this is kind of unfortunate but i see there isn't really much way around it right now without a very large refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #9218: [TVMC] Compose target options from target registry
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #9218:
URL: https://github.com/apache/tvm/pull/9218#discussion_r727534142
##########
File path: python/tvm/driver/tvmc/target.py
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Yip, I didn't realise `test_common.py` matched with `common.py`, so there'll be another PR at some point to split out the mixed set of things in `common.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org