[GitHub] [iotdb] HTHou commented on a change in pull request #3979: [IOTDB-1691] Wrong way of calculating the vector's memory footprint

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #3979:
URL: https://github.com/apache/iotdb/pull/3979#discussion_r709860352



##########
File path: server/src/main/java/org/apache/iotdb/db/utils/MemUtils.java
##########
@@ -101,40 +101,32 @@ public static long getRecordSize(
       return 0L;
     }
     long memSize = 0;
-    int columnCount = 0;
+    boolean hasVector = false;
     for (int i = 0; i < insertTabletPlan.getMeasurementMNodes().length; i++) {
       if (insertTabletPlan.getMeasurementMNodes()[i] == null) {
-        columnCount++;
         continue;
       }
       IMeasurementSchema schema = insertTabletPlan.getMeasurementMNodes()[i].getSchema();
+      TSDataType valueType;
       if (schema.getType() == TSDataType.VECTOR) {

Review comment:
       Can we use `if (insertTabletPlan.isAlign) ` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org