You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/07/22 17:54:03 UTC
Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case changes -
reading portable ip range from test_data.py file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23813/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-7044
https://issues.apache.org/jira/browse/CLOUDSTACK-7044
Repository: cloudstack-git
Description
-------
Changes:
1. Removing method "getPortableIpRangeServices" from common.py file
2. Reading the portable IP range data from test_data.py file
Diffs
-----
test/integration/component/test_portable_ip.py ce27dd8
tools/marvin/marvin/config/test_data.py 19b9aa4
tools/marvin/marvin/lib/common.py bc6b9c7
Diff: https://reviews.apache.org/r/23813/diff/
Testing
-------
Yes. Tested on KVM Advanced setup.
Thanks,
Ashutosh Kelkar
Re: Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case
changes - reading portable ip range from test_data.py file
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23813/#review48393
-----------------------------------------------------------
Commit 613eb12104af5c27935091127a1a19941f96e336 in cloudstack's branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=613eb12 ]
CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file
- ASF Subversion and Git Services
On July 22, 2014, 3:54 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23813/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 3:54 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7044
> https://issues.apache.org/jira/browse/CLOUDSTACK-7044
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Changes:
> 1. Removing method "getPortableIpRangeServices" from common.py file
> 2. Reading the portable IP range data from test_data.py file
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py ce27dd8
> tools/marvin/marvin/config/test_data.py 19b9aa4
> tools/marvin/marvin/lib/common.py bc6b9c7
>
> Diff: https://reviews.apache.org/r/23813/diff/
>
>
> Testing
> -------
>
> Yes. Tested on KVM Advanced setup.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case
changes - reading portable ip range from test_data.py file
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23813/#review49444
-----------------------------------------------------------
Commit 98e2a0444f74e3e8f6993319c822cc12bc491931 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=98e2a04 ]
Revert "CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file"
This reverts commit 613eb12104af5c27935091127a1a19941f96e336.
- ASF Subversion and Git Services
On July 22, 2014, 3:54 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23813/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 3:54 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7044
> https://issues.apache.org/jira/browse/CLOUDSTACK-7044
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Changes:
> 1. Removing method "getPortableIpRangeServices" from common.py file
> 2. Reading the portable IP range data from test_data.py file
>
>
> Diffs
> -----
>
> test/integration/component/test_portable_ip.py ce27dd8
> tools/marvin/marvin/config/test_data.py 19b9aa4
> tools/marvin/marvin/lib/common.py bc6b9c7
>
> Diff: https://reviews.apache.org/r/23813/diff/
>
>
> Testing
> -------
>
> Yes. Tested on KVM Advanced setup.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>