You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CzyerChen (via GitHub)" <gi...@apache.org> on 2024/03/12 09:18:47 UTC
[PR] fix(doc): fix the dev local port [skywalking-booster-ui]
CzyerChen opened a new pull request, #375:
URL: https://github.com/apache/skywalking-booster-ui/pull/375
The default UI address is `http://localhost:3000`.
```
VITE v4.5.2 ready in 2551 ms
➜ Local: http://localhost:3000/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #375:
URL: https://github.com/apache/skywalking-booster-ui/pull/375#issuecomment-1991257362
> @CzyerChen Please revert irrelevant parts, the doc fix is good.
reformatted by `prettier --write` automatically when committing, and can not revert.
<img width="869" alt="image" src="https://github.com/apache/skywalking-booster-ui/assets/22817918/ef465598-fdf9-4538-804c-128f795f3620">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on code in PR #375:
URL: https://github.com/apache/skywalking-booster-ui/pull/375#discussion_r1521131370
##########
README.md:
##########
@@ -34,14 +34,15 @@ npm install
npm run dev
```
-The default UI address is `http://localhost:8080`.
+The default UI address is `http://localhost:3000`.
Review Comment:
It's okay that the port is `3000` in `dev` mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #375:
URL: https://github.com/apache/skywalking-booster-ui/pull/375#discussion_r1521120700
##########
README.md:
##########
@@ -34,14 +34,15 @@ npm install
npm run dev
```
-The default UI address is `http://localhost:8080`.
+The default UI address is `http://localhost:3000`.
# Contact Us
-* Mail list: **dev@skywalking.apache.org**. Mail to `dev-subscribe@skywalking.apache.org`, follow the reply to subscribe to the mail list.
-* Send `Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
-* For Chinese speaker, send `[CN] Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
-* Twitter, [ASFSkyWalking](https://twitter.com/AsfSkyWalking)
-* [bilibili B站 视频](https://space.bilibili.com/390683219)
+
+- Mail list: **dev@skywalking.apache.org**. Mail to `dev-subscribe@skywalking.apache.org`, follow the reply to subscribe to the mail list.
+- Send `Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
+- For Chinese speaker, send `[CN] Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
+- Twitter, [ASFSkyWalking](https://twitter.com/AsfSkyWalking)
+- [bilibili B 站 视频](https://space.bilibili.com/390683219)
Review Comment:
Please don't reformat irrelevant codes.
##########
README.md:
##########
@@ -34,14 +34,15 @@ npm install
npm run dev
```
-The default UI address is `http://localhost:8080`.
+The default UI address is `http://localhost:3000`.
Review Comment:
@Fine0830 Please confirm. Should we get this on 8080 to align with webspp deployment mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #375:
URL: https://github.com/apache/skywalking-booster-ui/pull/375#issuecomment-1991189939
@CzyerChen Please revert irrelevant parts, the doc fix is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #375:
URL: https://github.com/apache/skywalking-booster-ui/pull/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org