You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yangguangcai01 (via GitHub)" <gi...@apache.org> on 2024/09/27 23:48:15 UTC
[PR] Capture [nuttx]
yangguangcai01 opened a new pull request, #13701:
URL: https://github.com/apache/nuttx/pull/13701
## Summary
When monitoring multiple capture channels, the `ioctl` function is called three times, leading to significant overhead mainly due to VFS and `nxmutex_lock/unlock`. Adding a new interface can save the overhead of two `ioctl` calls.
## Impact
get capture freq/duty/edges by ioctl.
## Testing
chip:cortexM7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Capture [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13701:
URL: https://github.com/apache/nuttx/pull/13701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Capture [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13701:
URL: https://github.com/apache/nuttx/pull/13701#issuecomment-2380296834
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**No, the PR does not meet the NuttX requirements.**
Here's why and how to fix it:
**Missing Information:**
* **Summary:**
* **Why is the change necessary?** You mention overhead, but not why it's a problem (performance bottleneck, specific use-case impacted). Quantify the overhead (e.g., "reduces execution time by X%").
* **What is being changed?** Be more specific. What is the new interface? What code is modified?
* **Impact:**
* **New/Changed Feature:** Clearly state if the new interface is a replacement or addition. If a replacement, is the old interface deprecated?
* **User Impact:** Will users need to modify their code to use the new interface? If so, how?
* **Other Impacts:** You've marked most as "NO" without explanation. Even if there's no impact, briefly state it (e.g., "Build: NO - No changes to the build process").
* **Testing:**
* **Insufficient Detail:**
* Provide the OS and compiler used on your build host.
* Specify the exact Cortex-M7 board and configuration used.
* **No Logs:** Include actual testing logs from before and after the change to demonstrate the improvement.
**How to Improve the PR:**
1. **Expand the Summary:** Clearly explain the problem, the proposed solution, and the expected benefits (with some quantification if possible).
2. **Detailed Impact Assessment:** Address all impact categories, providing brief explanations even if there's no impact.
3. **Thorough Testing Information:**
* Provide complete details about your build and target environments.
* Include actual log snippets showing the overhead reduction. Consider using profiling tools for more concrete evidence.
By addressing these points, your PR will be more likely to be accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org