[GitHub] [hadoop] goiri commented on a diff in pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

["goiri (via GitHub)" <gi...@apache.org>]

goiri commented on code in PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#discussion_r1098998010


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterState.java:
##########
@@ -55,6 +55,10 @@ public boolean isUnusable() {
     return (this != SC_RUNNING && this != SC_NEW);
   }
 
+  public boolean isUsable() {
+    return !isUnusable();

Review Comment:
   Let's remove isUnusable() and always use isUsable with ! and so on.
   Negative methods are usually not recommended.



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -4299,6 +4299,11 @@ public static boolean isAclEnabled(Configuration conf) {
       ROUTER_PREFIX + "interceptor.allow-partial-result.enable";
   public static final boolean DEFAULT_ROUTER_INTERCEPTOR_ALLOW_PARTIAL_RESULT_ENABLED = false;
 
+  /** Subcluster timeout allowed by Router.  **/
+  public static final String ROUTER_SUBCLUSTER_EXPIRATION_TIME =
+      ROUTER_PREFIX + "subcluster.heartbeat.expiration.time";
+  public static final long DEFAULT_ROUTER_SUBCLUSTER_EXPIRATION_TIME = 1800000;

Review Comment:
   Make it TimeUnit



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java:
##########
@@ -37,12 +66,48 @@ public RouterCLI(Configuration conf) {
     super(conf);
   }
 
+  private static void buildHelpMsg(String cmd, StringBuilder builder) {
+    UsageInfo usageInfo = ADMIN_USAGE.get(cmd);
+    if (usageInfo == null) {
+      return;
+    }
+
+    if (usageInfo.args != null) {
+      String space = (usageInfo.args == "") ? "" : " ";
+      builder.append("   " + cmd + space + usageInfo.args + ": "
+              + usageInfo.help);
+    } else {
+      builder.append("   " + cmd + ": " + usageInfo.help);
+    }
+  }
+
+  private static void buildIndividualUsageMsg(String cmd, StringBuilder builder) {
+    UsageInfo usageInfo = ADMIN_USAGE.get(cmd);
+    if (usageInfo == null) {
+      return;
+    }
+    if (usageInfo.args == null) {
+      builder.append("Usage: routeradmin [" + cmd + "]\n");

Review Comment:
   If we have a StringBuilder, use append not +



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org