You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/17 11:17:54 UTC
[GitHub] [nuttx] flyingfish89 opened a new pull request, #8164: add holder for mutex
flyingfish89 opened a new pull request, #8164:
URL: https://github.com/apache/nuttx/pull/8164
## Summary
add holder for mutex
## Impact
remove holder from rmutex and add holder for mutex
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#discussion_r1073443964
##########
include/semaphore.h:
##########
@@ -42,6 +42,7 @@
#define SEM_PRIO_INHERIT 1
#define SEM_PRIO_PROTECT 2
#define SEM_PRIO_MASK 3
+#define SEM_PRIO_MUTEX 4
Review Comment:
```suggestion
#define SEM_TYPE_MUTEX 4
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1387016242
> @flyingfish89
>
> I noticed that sim:usrsocktest causes assert with this PR.
>
> ```
> nsh> uname -a
> NuttX 12.0.0 a4c9da9280 Jan 18 2023 20:32:01 sim sim
> nsh> usrsocktest
> Starting unit-tests...
> Testing group "char_dev" =>
> Group "char_dev": [OK]
> Testing group "no_daemon" =>
> Group "no_daemon": [OK]
> Testing group "basic_daemon" =>
> Group "basic_daemon": [OK]
> Testing group "basic_connect" =>
> Group "basic_connect": [OK]
> Testing group "basic_connect_delay" =>
> Group "basic_connect_delay": [OK]
> Testing group "no_block_connect" =>
> Group "no_block_connect": [OK]
> Testing group "basic_send" =>
> Group "basic_send": [OK]
> Testing group "no_block_send" =>
> Group "no_block_send": [OK]
> Testing group "block_send" =>
> Group "block_send": [OK]
> Testing group "no_block_recv" =>
> Group "no_block_recv": [OK]
> Testing group "block_recv" =>
> Group "block_recv": [OK]
> Testing group "remote_disconnect" =>
> Group "remote_disconnect": [OK]
> Testing group "basic_setsockopt" =>
> Group "basic_setsockopt": [OK]
> Testing group "basic_getsockopt" =>
> Group "basic_getsockopt": [OK]
> Testing group "basic_getsockname" =>
> Group "basic_getsockname": [OK]
> Testing group "wake_with_signal" =>
> _assert: Current Version: NuttX 12.0.0 a4c9da9280 Jan 18 2023 20:32:01 sim
> _assert: Assertion failed at file: usrsock/usrsock_devif.c:709 task: <pthread> 0x5619e6fec5ad
> ```
I just tried sim:usrsocktest with the last master(c19b5eeb8d8f37394c79ff85876c7ba6d846fc12), all test can pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jerpelea commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
jerpelea commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1387050591
+1 for revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#discussion_r1073545950
##########
include/semaphore.h:
##########
@@ -42,6 +42,7 @@
#define SEM_PRIO_INHERIT 1
#define SEM_PRIO_PROTECT 2
#define SEM_PRIO_MASK 3
+#define SEM_PRIO_MUTEX 4
Review Comment:
@pkarashchenko here is the patch: https://github.com/apache/nuttx/pull/8182/commits/d45ac2b157e7b9e486708ac375a44b21c4d90303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1387085158
> @xiaoxiang781216
>
> > I just tried sim:usrsocktest with the last master([c19b5ee](https://github.com/apache/nuttx/commit/c19b5eeb8d8f37394c79ff85876c7ba6d846fc12)), all test can pass.
>
> Please try the test with `CONFIG_DEBUG_ASSERTIONS=y`
Ok, I can repro the problem now. @masayuki2009 could you try this patch: https://github.com/apache/nuttx/pull/8164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1387049087
Shall we revert this PR because there are some issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1386910504
@flyingfish89
I noticed that sim:usrsocktest causes assert with this PR?
```
nsh> uname -a
NuttX 12.0.0 a4c9da9280 Jan 18 2023 20:32:01 sim sim
nsh> usrsocktest
Starting unit-tests...
Testing group "char_dev" =>
Group "char_dev": [OK]
Testing group "no_daemon" =>
Group "no_daemon": [OK]
Testing group "basic_daemon" =>
Group "basic_daemon": [OK]
Testing group "basic_connect" =>
Group "basic_connect": [OK]
Testing group "basic_connect_delay" =>
Group "basic_connect_delay": [OK]
Testing group "no_block_connect" =>
Group "no_block_connect": [OK]
Testing group "basic_send" =>
Group "basic_send": [OK]
Testing group "no_block_send" =>
Group "no_block_send": [OK]
Testing group "block_send" =>
Group "block_send": [OK]
Testing group "no_block_recv" =>
Group "no_block_recv": [OK]
Testing group "block_recv" =>
Group "block_recv": [OK]
Testing group "remote_disconnect" =>
Group "remote_disconnect": [OK]
Testing group "basic_setsockopt" =>
Group "basic_setsockopt": [OK]
Testing group "basic_getsockopt" =>
Group "basic_getsockopt": [OK]
Testing group "basic_getsockname" =>
Group "basic_getsockname": [OK]
Testing group "wake_with_signal" =>
_assert: Current Version: NuttX 12.0.0 a4c9da9280 Jan 18 2023 20:32:01 sim
_assert: Assertion failed at file: usrsock/usrsock_devif.c:709 task: <pthread> 0x5619e6fec5ad
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1387048178
@flyingfish89
spresense:rndis_smp is unstable now (i.e. ping does not work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1386970935
@flyingfish89
>I noticed that sim:usrsocktest causes assert with this PR.
It seems that this PR causes deadlock with ostest (e.g. rp2040:smp with CONFIG_DEBUG_ASSERTIONS=y).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8164:
URL: https://github.com/apache/nuttx/pull/8164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #8164: add holder for mutex
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #8164:
URL: https://github.com/apache/nuttx/pull/8164#issuecomment-1387024832
@xiaoxiang781216
>I just tried sim:usrsocktest with the last master(https://github.com/apache/nuttx/commit/c19b5eeb8d8f37394c79ff85876c7ba6d846fc12), all test can pass.
Please try the test with `CONFIG_DEBUG_ASSERTIONS=y`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org