You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2014/11/13 18:42:02 UTC
Review Request 27998: Repository Version Management - Add validation
for created repo versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-8314
https://issues.apache.org/jira/browse/AMBARI-8314
Repository: ambari
Description
-------
Add some validation when creating a repo version:
* validate the stack exists
* upgrade pack specified is available for the stack
* validate the OS specified for repositories are all in the stack available
* validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
Diff: https://reviews.apache.org/r/27998/diff/
Testing
-------
in progress
Thanks,
Yurii Shylov
Re: Review Request 27998: Repository Version Management - Add
validation for created repo versions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/#review61277
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 13, 2014, 12:42 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27998/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 12:42 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8314
> https://issues.apache.org/jira/browse/AMBARI-8314
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some validation when creating a repo version:
> * validate the stack exists
> * upgrade pack specified is available for the stack
> * validate the OS specified for repositories are all in the stack available
> * validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
>
> Diff: https://reviews.apache.org/r/27998/diff/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27998: Repository Version Management - Add
validation for created repo versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/#review61454
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 14, 2014, 4:35 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27998/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 4:35 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8314
> https://issues.apache.org/jira/browse/AMBARI-8314
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some validation when creating a repo version:
> * validate the stack exists
> * upgrade pack specified is available for the stack
> * validate the OS specified for repositories are all in the stack available
> * validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
>
> Diff: https://reviews.apache.org/r/27998/diff/
>
>
> Testing
> -------
>
> 3 python tests fail, but they fail on trunk as well. Java test ok, this patch affects only java code
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27998: Repository Version Management - Add
validation for created repo versions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/#review61452
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 14, 2014, 11:35 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27998/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 11:35 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8314
> https://issues.apache.org/jira/browse/AMBARI-8314
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some validation when creating a repo version:
> * validate the stack exists
> * upgrade pack specified is available for the stack
> * validate the OS specified for repositories are all in the stack available
> * validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
>
> Diff: https://reviews.apache.org/r/27998/diff/
>
>
> Testing
> -------
>
> 3 python tests fail, but they fail on trunk as well. Java test ok, this patch affects only java code
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27998: Repository Version Management - Add
validation for created repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/
-----------------------------------------------------------
(Updated Ноя. 14, 2014, 4:35 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-8314
https://issues.apache.org/jira/browse/AMBARI-8314
Repository: ambari
Description
-------
Add some validation when creating a repo version:
* validate the stack exists
* upgrade pack specified is available for the stack
* validate the OS specified for repositories are all in the stack available
* validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
Diff: https://reviews.apache.org/r/27998/diff/
Testing (updated)
-------
3 python tests fail, but they fail on trunk as well. Java test ok, this patch affects only java code
Thanks,
Yurii Shylov
Re: Review Request 27998: Repository Version Management - Add
validation for created repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/
-----------------------------------------------------------
(Updated Ноя. 14, 2014, 4:34 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Fixed failing tests
Bugs: AMBARI-8314
https://issues.apache.org/jira/browse/AMBARI-8314
Repository: ambari
Description
-------
Add some validation when creating a repo version:
* validate the stack exists
* upgrade pack specified is available for the stack
* validate the OS specified for repositories are all in the stack available
* validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
Diff: https://reviews.apache.org/r/27998/diff/
Testing
-------
in progress
Thanks,
Yurii Shylov
Re: Review Request 27998: Repository Version Management - Add
validation for created repo versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27998/#review61435
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 13, 2014, 5:42 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27998/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 5:42 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8314
> https://issues.apache.org/jira/browse/AMBARI-8314
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add some validation when creating a repo version:
> * validate the stack exists
> * upgrade pack specified is available for the stack
> * validate the OS specified for repositories are all in the stack available
> * validate that the version specified is valid for the upgrade pack. this will involve changing the upgrade pack "target" element to a regex appropriately
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 502a94e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 2debfd3
>
> Diff: https://reviews.apache.org/r/27998/diff/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Yurii Shylov
>
>