You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/31 06:20:44 UTC
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4183
to review the following change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
ksck: add --checksum_scan_concurrency to optional flags
Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
---
M src/kudu/tools/tool_action_cluster.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4183/1
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3179/
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4183/1/src/kudu/tools/tool_action_cluster.cc
File src/kudu/tools/tool_action_cluster.cc:
Line 133: "Comma-separated list of Kudu Master addressess where each address is "
> not your fault, but can you fix this typo?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4183/1/src/kudu/tools/tool_action_cluster.cc
File src/kudu/tools/tool_action_cluster.cc:
Line 133: "Comma-separated list of Kudu Master addressess where each address is "
not your fault, but can you fix this typo?
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
Patch Set 1: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/3168/
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3164/
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
ksck: add --checksum_scan_concurrency to optional flags
Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Reviewed-on: http://gerrit.cloudera.org:8080/4183
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M src/kudu/tools/tool_action_cluster.cc
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4183
to look at the new patch set (#2).
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
ksck: add --checksum_scan_concurrency to optional flags
Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
---
M src/kudu/tools/tool_action_cluster.cc
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4183/2
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] ksck: add --checksum scan concurrency to optional flags
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: ksck: add --checksum_scan_concurrency to optional flags
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa76215e0c30860eebd99db0548b3b37dd2e60e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No