You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/07 08:48:18 UTC

[GitHub] XD-DENG commented on a change in pull request #3861: [AIRFLOW-XXX] Fix doc of command line interface

XD-DENG commented on a change in pull request #3861: [AIRFLOW-XXX] Fix doc of command line interface
URL: https://github.com/apache/incubator-airflow/pull/3861#discussion_r215888710
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -1457,7 +1457,7 @@ class CLIFactory(object):
         'subdir': Arg(
             ("-sd", "--subdir"),
             "File location or directory from which to look for the dag",
-            default=settings.DAGS_FOLDER),
+            default="[AIRFLOW_HOME]/dags"),
 
 Review comment:
   You're right. Didn't realize this. I would leave this to @kaxil to decide how he would like to fix this (please feel free to close this PR should you're going to fix this separately).
   
   But we do need to fix this. `Default: /Users/kaxil/airflow/dags` in the documentation is very confusing and misleading to doc readers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services