You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/28 10:16:56 UTC

[GitHub] [airflow] ashb commented on a change in pull request #4554: [AIRFLOW-3729] Support env variables with pod runtime information in KubernetesPodOperator

ashb commented on a change in pull request #4554: [AIRFLOW-3729] Support env variables with pod runtime information in KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/4554#discussion_r288029184
 
 

 ##########
 File path: airflow/kubernetes/pod.py
 ##########
 @@ -69,7 +69,9 @@ class Pod:
     :param configmaps: A list containing names of configmaps object
         mounting env variables to the pod
     :type configmaps: list[str]
-
+    :param pod_runtime_info_envs: environment variables about
+                                  pod runtime information (ip, namespace, nodeName, podName)
+    :type pod_runtime_info_envs: list of PodRuntimeEnv
 
 Review comment:
   ```suggestion
       :type pod_runtime_info_envs: list[PodRuntimeEnv]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services