[jira] [Commented] (LUCENE-10002) Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)

["Greg Miller (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362937#comment-17362937 ] 

Greg Miller commented on LUCENE-10002:
--------------------------------------

+1. I also don't love that users can setup an {{IndexSearcher}} with an {{Executor}} and then not leverage it since they're not providing a {{CollectorManager}}. We have the same mixed pattern in {{DrillSideways}} as well. If we end up moving forward with this change in {{IndexSearcher}}, I'll create another issue to make the same update in {{DrillSideways}} for consistency.

> Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10002
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10002
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> It's a bit trappy that you can create an IndexSearcher with an executor, but that it would always search on the caller thread when calling {{IndexSearcher#search(Query,Collector)}}.
>  Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to return a {{CollectorManager}} instead of a {{Collector}}?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org