You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2022/01/12 03:50:03 UTC

[jira] [Updated] (BEAM-6904) Test all Coder structuralValue implementations

     [ https://issues.apache.org/jira/browse/BEAM-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles updated BEAM-6904:
----------------------------------

This Jira ticket has a pull request attached to it, but is still open. Did the pull request resolve the issue? If so, could you please mark it resolved? This will help the project have a clear view of its open issues.

> Test all Coder structuralValue implementations
> ----------------------------------------------
>
>                 Key: BEAM-6904
>                 URL: https://issues.apache.org/jira/browse/BEAM-6904
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: P3
>              Labels: Clarified, beam-fixit
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Here is a test helper that check that structuralValue is consistent with equals: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L200
> And here is one that tests it another way: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L226
> With the deprecation of consistentWithEquals and implementing all the structualValue methods, we should add these tests to every coder.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)