You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/08 22:08:38 UTC
[GitHub] [hive] asinkovits opened a new pull request #1961: HIVE-24726: Track required data for cache hydration
asinkovits opened a new pull request #1961:
URL: https://github.com/apache/hive/pull/1961
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
This is a subtask for the cache hydration feature, collecting the required data for storing and restoring the cache content.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
LLAP cache hydration will enable save/load the cache contents. To do this some additional metadata is required.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests were added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta commented on a change in pull request #1961: HIVE-24726: Track required data for cache hydration
Posted by GitBox <gi...@apache.org>.
szlta commented on a change in pull request #1961:
URL: https://github.com/apache/hive/pull/1961#discussion_r573618773
##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryLimitedPathCache.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.llap.cache;
+
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.Weigher;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Memory limited version of the path cache.
+ */
+public class MemoryLimitedPathCache implements PathCache {
+
+ private static final Logger LOG = LoggerFactory.getLogger(MemoryLimitedPathCache.class);
+ private Cache<Object, String> internalCache;
+
+ public MemoryLimitedPathCache(Configuration conf) {
+ internalCache = CacheBuilder.newBuilder()
+ .maximumWeight(HiveConf.getSizeVar(conf, HiveConf.ConfVars.LLAP_IO_PATH_CACHE_SIZE))
+ .weigher(new PathWeigher())
+ .build();
+ }
+
+ @Override
+ public void touch(Object key, String val) {
+ if (key != null) {
+ internalCache.put(key, val);
+ }
+ }
+
+ @Override
+ public String resolve(Object key) {
+ return key != null ? internalCache.getIfPresent(key) : null;
+ }
+
+ private static class PathWeigher implements Weigher<Object, String> {
+
+ @Override
+ public int weigh(Object key, String value) {
+ // String memory footprint
Review comment:
Please add more comments on why this is calculated like this.
##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -112,6 +115,8 @@
private final BufferUsageManager bufferManager;
private final Configuration daemonConf;
private final LowLevelCacheMemoryManager memoryManager;
+ private LowLevelCachePolicy realCachePolicy;
Review comment:
Why was this refactor necessary? (similarly why for tracePool)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits commented on a change in pull request #1961: HIVE-24726: Track required data for cache hydration
Posted by GitBox <gi...@apache.org>.
asinkovits commented on a change in pull request #1961:
URL: https://github.com/apache/hive/pull/1961#discussion_r577739161
##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -112,6 +115,8 @@
private final BufferUsageManager bufferManager;
private final Configuration daemonConf;
private final LowLevelCacheMemoryManager memoryManager;
+ private LowLevelCachePolicy realCachePolicy;
Review comment:
Both will be required in HIVE-24727, I've reverted them for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits commented on a change in pull request #1961: HIVE-24726: Track required data for cache hydration
Posted by GitBox <gi...@apache.org>.
asinkovits commented on a change in pull request #1961:
URL: https://github.com/apache/hive/pull/1961#discussion_r577739515
##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryLimitedPathCache.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.llap.cache;
+
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.cache.Weigher;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Memory limited version of the path cache.
+ */
+public class MemoryLimitedPathCache implements PathCache {
+
+ private static final Logger LOG = LoggerFactory.getLogger(MemoryLimitedPathCache.class);
+ private Cache<Object, String> internalCache;
+
+ public MemoryLimitedPathCache(Configuration conf) {
+ internalCache = CacheBuilder.newBuilder()
+ .maximumWeight(HiveConf.getSizeVar(conf, HiveConf.ConfVars.LLAP_IO_PATH_CACHE_SIZE))
+ .weigher(new PathWeigher())
+ .build();
+ }
+
+ @Override
+ public void touch(Object key, String val) {
+ if (key != null) {
+ internalCache.put(key, val);
+ }
+ }
+
+ @Override
+ public String resolve(Object key) {
+ return key != null ? internalCache.getIfPresent(key) : null;
+ }
+
+ private static class PathWeigher implements Weigher<Object, String> {
+
+ @Override
+ public int weigh(Object key, String value) {
+ // String memory footprint
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta merged pull request #1961: HIVE-24726: Track required data for cache hydration
Posted by GitBox <gi...@apache.org>.
szlta merged pull request #1961:
URL: https://github.com/apache/hive/pull/1961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org