You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/25 14:36:37 UTC
[GitHub] [flink-benchmarks] pnowojski commented on a change in pull request #17: [FLINK-23078] Fix SchedulerBenchmarkExecutorBase#teardown
pnowojski commented on a change in pull request #17:
URL: https://github.com/apache/flink-benchmarks/pull/17#discussion_r658813715
##########
File path: src/main/java/org/apache/flink/scheduler/benchmark/SchedulerBenchmarkBase.java
##########
@@ -55,4 +58,10 @@ public static void runBenchmark(Class<?> clazz) throws RunnerException {
new Runner(options).run();
}
+
+
+ @TearDown
+ public void teardown() {
+ SchedulerBenchmarkUtils.shutdownTestingUtilDefaultExecutor();
Review comment:
Sorry, I'm confused. Why do we need this? It's again the same problem as with old `TestingUtils`. It's a class defined in `flink` repository, which is not part of the `Flink's` public API. Why can not we call this `shutdownTestingUtilDefaultExecutor()` in `org.apache.flink.runtime.scheduler.benchmark.e2e.SchedulerBenchmarkBase#teardown`?
##########
File path: src/main/java/org/apache/flink/scheduler/benchmark/SchedulerBenchmarkExecutorBase.java
##########
@@ -48,7 +48,7 @@
"-Dcom.sun.management.jmxremote.ssl=false",
"-Dcom.sun.management.jmxremote.ssl"
})
-public class SchedulerBenchmarkBase {
+public class SchedulerBenchmarkExecutorBase {
Review comment:
+1 for renaming `SchedulerBenchmarkExecutorBase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org