You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/21 00:54:32 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34341: [SPARK-37076][SQL] Implement StructType.toString explicitly for Scala 2.13

HyukjinKwon commented on a change in pull request #34341:
URL: https://github.com/apache/spark/pull/34341#discussion_r733244498



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala
##########
@@ -127,6 +127,10 @@ case class StructType(fields: Array[StructField]) extends DataType with Seq[Stru
     }
   }
 
+  override def toString(): String = {
+    s"StructType${fields.map(_.toString).mkString("(", ",", ")")}"

Review comment:
       Should we better use getClass.getName?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org