[GitHub] [incubator-superset] villebro commented on pull request #10324: feat: add optional prophet forecasting functionality to chart data api

[GitBox <gi...@apache.org>]

villebro commented on pull request #10324:
URL: https://github.com/apache/incubator-superset/pull/10324#issuecomment-660921855


   @willbarrett this is ready for re-review. I split out the training part into a private method to make the main method simpler (was able to drop the `disable too-many-locals`), and also made each unit test a separate function. However, the `too-many-arguments` can't really be changed due to the nature of how post processing operations are called from the chart data API.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org