[helix] branch master updated: Fix wrong logging for instance validation (#1490)

[jx...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jxue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new eec4de7  Fix wrong logging for instance validation (#1490)
eec4de7 is described below

commit eec4de734ed23c2f64bc8c5c8a94b74ef52ee182
Author: Junkai Xue <jx...@linkedin.com>
AuthorDate: Wed Oct 28 14:47:39 2020 -0700

    Fix wrong logging for instance validation (#1490)
---
 .../src/main/java/org/apache/helix/util/InstanceValidationUtil.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java b/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
index e3a98c1..fb3c4f9 100644
--- a/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
+++ b/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
@@ -114,7 +114,7 @@ public class InstanceValidationUtil {
       }
     }
 
-    _logger.warn(String.format("The instance %s is not active", instanceName));
+    _logger.warn(String.format("The instance %s does not have resource assigned on it.", instanceName));
     return false;
   }
 
@@ -196,12 +196,12 @@ public class InstanceValidationUtil {
         CurrentState currentState = dataAccessor.getProperty(key);
         if (currentState != null
             && currentState.getPartitionStateMap().containsValue(HelixDefinedState.ERROR.name())) {
+          _logger.warn(String.format("The instance %s has error partitions on it.", instanceName));
           return true;
         }
       }
     }
 
-    _logger.warn(String.format("The instance %s is not active", instanceName));
     return false;
   }