You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/27 00:32:50 UTC

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10177: feat: Switch from nosetest to pytest

ktmud commented on a change in pull request #10177:
URL: https://github.com/apache/incubator-superset/pull/10177#discussion_r446460553



##########
File path: scripts/python_tests.sh
##########
@@ -23,5 +23,5 @@ echo "Superset config module: $SUPERSET_CONFIG"
 
 superset db upgrade
 superset init
-nosetests --stop tests/load_examples_test.py
-nosetests --stop --exclude=load_examples_test tests
+pytest --maxfail=1  tests/load_examples_test.py

Review comment:
       Do we want coverage for this file as well? I don't think it's needed but it was covered in previous setup.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org