You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/08/07 05:38:33 UTC

[kudu-CR] WIP: DeltaFile tests 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11140

to review the following change.


Change subject: WIP: DeltaFile tests
......................................................................

WIP: DeltaFile tests

WIP because what's here needs to be refactored into useful test helpers
that are then used in actual tests.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/tablet/deltafile-test.cc
1 file changed, 69 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#6).

Change subject: deltafile-test: DeltaFileIterator fuzz test
......................................................................

deltafile-test: DeltaFileIterator fuzz test

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the various delta iterator
functions.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
7 files changed, 481 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/6
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#11).

Change subject: deltas: fuzz tests for delta file and dms
......................................................................

deltas: fuzz tests for delta file and dms

Here are new fuzz tests for deltafile-test and deltamemstore-test that
generate random deltas and iterate over them using random snapshots, testing
the various delta iterator functions. I found this to be a simpler
environment in which to debug delta-related issues, vs. more heavy-weight
tests (i.e. fuzz-itest).

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file or DMS.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
8 files changed, 768 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/11
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 11
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#4).

Change subject: deltafile-test: DeltaFileIterator fuzz test
......................................................................

deltafile-test: DeltaFileIterator fuzz test

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the various delta iterator
functions.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
7 files changed, 469 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#12).

Change subject: deltas: fuzz tests for delta file and dms
......................................................................

deltas: fuzz tests for delta file and dms

Here are new fuzz tests for deltafile-test and deltamemstore-test that
generate random deltas and iterate over them using random snapshots, testing
the various delta iterator functions. I found this to be a simpler
environment in which to debug delta-related issues, vs. more heavy-weight
tests (i.e. fuzz-itest).

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file or DMS.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/common/columnblock.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
9 files changed, 804 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/12
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 12
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 11
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#7).

Change subject: deltafile-test: DeltaFileIterator fuzz test
......................................................................

deltafile-test: DeltaFileIterator fuzz test

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the various delta iterator
functions.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
7 files changed, 481 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/7
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................


Patch Set 15:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h
File src/kudu/tablet/tablet-test-util.h:

http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@354
PS15, Line 354:    T::kTag == REDO,
              :    std::less<Timestamp>,
              :    std::greater<Timestamp>>::type;
> nit: unusual indentation
Done


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@454
PS15, Line 454:   // Transforms and writes deltas into 'deltas', a vector of "delta lists", each
> please add a description of the semantics of this method (what it's doing /
I don't think your suggestion is adding more information than already exists. "Collect all mutations" is implied by the method name. And "relevant to a scan at timestamp ts" is already mentioned in the second paragraph, in "Deltas not relevant to 'ts' are skipped".


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@467
PS15, Line 467: continue
> break?
Done


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@750
PS15, Line 750: // Runs a fuzz test by generating a fairly random DeltaIterator, using it to
> Clarify what component is being tested here
Done


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@772
PS15, Line 772: inclusive snapshot
> what does this mean? the prng->Uniform() logic below treats .second as excl
Yeah this wasn't clear. This is referring to how when i == kNumScans, the snapshot we use is "totally inclusive", which is an ambiguous way of saying "a snapshot for which all deltas are relevant".


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@810
PS15, Line 810:  - 1
> nit: no need for this -1 because Random::Uniform() returns values from [0 .
Done


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.cc
File src/kudu/tablet/tablet-test-util.cc:

http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.cc@26
PS15, Line 26: to_include > ts;
> nit: maybe it's just me, but I usually think of this as ts < to_include, be
Done


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.cc@32
PS15, Line 32: to_include <= ts
> same here, I usually think of this as ts >= to_include
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 15
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 04:00:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#5).

Change subject: deltafile-test: DeltaFileIterator fuzz test
......................................................................

deltafile-test: DeltaFileIterator fuzz test

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the various delta iterator
functions.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
7 files changed, 469 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................


Patch Set 17: Code-Review+2

Carrying forward Mike's +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 17
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 31 Oct 2018 23:57:56 +0000
Gerrit-HasComments: No

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................

deltas: fuzz tests for delta file and dms

Here are new fuzz tests for deltafile-test and deltamemstore-test that
generate random deltas and iterate over them using random snapshots, testing
the various delta iterator functions. I found this to be a simpler
environment in which to debug delta-related issues, vs. more heavy-weight
tests (i.e. fuzz-itest).

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file or DMS.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Reviewed-on: http://gerrit.cloudera.org:8080/11140
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/columnblock.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
9 files changed, 810 insertions(+), 20 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 18
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#8).

Change subject: deltafile-test: DeltaFileIterator fuzz test
......................................................................

deltafile-test: DeltaFileIterator fuzz test

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the various delta iterator
functions.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
7 files changed, 481 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/8
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#16).

Change subject: deltas: fuzz tests for delta file and dms
......................................................................

deltas: fuzz tests for delta file and dms

Here are new fuzz tests for deltafile-test and deltamemstore-test that
generate random deltas and iterate over them using random snapshots, testing
the various delta iterator functions. I found this to be a simpler
environment in which to debug delta-related issues, vs. more heavy-weight
tests (i.e. fuzz-itest).

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file or DMS.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/common/columnblock.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
9 files changed, 810 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/16
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 16
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................


Patch Set 11: Verified+1

Overriding Jenkins, another instance of KUDU-2212.


-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 11
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 16:05:53 +0000
Gerrit-HasComments: No

[kudu-CR] deltafile-test: fuzz test for ApplyUpdates and ApplyDeletes

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#3).

Change subject: deltafile-test: fuzz test for ApplyUpdates and ApplyDeletes
......................................................................

deltafile-test: fuzz test for ApplyUpdates and ApplyDeletes

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the ApplyUpdates and
ApplyDeletes delta iterator functionality.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
6 files changed, 360 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................


Patch Set 15:

(8 comments)

looks good overall

http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h
File src/kudu/tablet/tablet-test-util.h:

http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@354
PS15, Line 354:    T::kTag == REDO,
              :    std::less<Timestamp>,
              :    std::greater<Timestamp>>::type;
nit: unusual indentation


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@454
PS15, Line 454:   // Transforms and writes deltas into 'deltas', a vector of "delta lists", each
please add a description of the semantics of this method (what it's doing / why it should be called); only technical details have been provided so far in this comment

maybe just: Collect all mutations relevant to a scan at timestamp ts.


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@467
PS15, Line 467: continue
break?


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@750
PS15, Line 750: // Runs a fuzz test by generating a fairly random DeltaIterator, using it to
Clarify what component is being tested here


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@772
PS15, Line 772: inclusive snapshot
what does this mean? the prng->Uniform() logic below treats .second as exclusive


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.h@810
PS15, Line 810:  - 1
nit: no need for this -1 because Random::Uniform() returns values from [0 .. n-1]


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.cc
File src/kudu/tablet/tablet-test-util.cc:

http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.cc@26
PS15, Line 26: to_include > ts;
nit: maybe it's just me, but I usually think of this as ts < to_include, because to_include is sort of fixed, but obviously it's the same thing so feel free to ignore this


http://gerrit.cloudera.org:8080/#/c/11140/15/src/kudu/tablet/tablet-test-util.cc@32
PS15, Line 32: to_include <= ts
same here, I usually think of this as ts >= to_include



-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 15
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 19:06:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] deltafile-test: fuzz test for ApplyUpdates and ApplyDeletes

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#2).

Change subject: deltafile-test: fuzz test for ApplyUpdates and ApplyDeletes
......................................................................

deltafile-test: fuzz test for ApplyUpdates and ApplyDeletes

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the ApplyUpdates and
ApplyDeletes delta iterator functionality.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

I snuck in a change to map-util.h that I ultimately didn't use, but could be
useful for others.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/gutil/map-util.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
6 files changed, 360 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltafile-test: DeltaFileIterator fuzz test

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#9).

Change subject: deltafile-test: DeltaFileIterator fuzz test
......................................................................

deltafile-test: DeltaFileIterator fuzz test

Here's a new fuzz test for deltafile-test that generates random deltas and
iterates at random snapshots over it, testing the various delta iterator
functions.

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file (or into a DMS, for that matter).

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
6 files changed, 474 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/9
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 9
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 )

Change subject: deltas: fuzz tests for delta file and dms
......................................................................


Patch Set 16: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 16
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 22:37:25 +0000
Gerrit-HasComments: No

[kudu-CR] deltas: fuzz tests for delta file and dms

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11140

to look at the new patch set (#15).

Change subject: deltas: fuzz tests for delta file and dms
......................................................................

deltas: fuzz tests for delta file and dms

Here are new fuzz tests for deltafile-test and deltamemstore-test that
generate random deltas and iterate over them using random snapshots, testing
the various delta iterator functions. I found this to be a simpler
environment in which to debug delta-related issues, vs. more heavy-weight
tests (i.e. fuzz-itest).

The test introduces MirroredDeltas, a utility that's useful for tracking
deltas that are written into a delta file or DMS.

Change-Id: I539ff0f2055cf398a42efb824238188230e25516
---
M src/kudu/common/columnblock.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
A src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
9 files changed, 804 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/15
-- 
To view, visit http://gerrit.cloudera.org:8080/11140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516
Gerrit-Change-Number: 11140
Gerrit-PatchSet: 15
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>