You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/11/30 14:16:27 UTC

[GitHub] [jena] rvesse opened a new pull request, #1641: Use distinctAdjacent for TDB 2 graph iteration (GH-1639)

rvesse opened a new pull request, #1641:
URL: https://github.com/apache/jena/pull/1641

   When the primary index is G??? based use distinctAdjacent() rather than distinct() when listing graph nodes for TDB 2.  This provides some speedup and a constant memory footprint for this iteration as we only have to remember the previous graph name not all the graph names.
   
   This partially addresses #1639, in my testing it yields about a 20% speed up on some synthetic test datasets.
   
   ----
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] afs merged pull request #1641: Use distinctAdjacent for TDB 2 graph iteration (GH-1639)

Posted by GitBox <gi...@apache.org>.
afs merged PR #1641:
URL: https://github.com/apache/jena/pull/1641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] rvesse commented on pull request #1641: Use distinctAdjacent for TDB 2 graph iteration (GH-1639)

Posted by GitBox <gi...@apache.org>.
rvesse commented on PR #1641:
URL: https://github.com/apache/jena/pull/1641#issuecomment-1332420827

   Yes I see your PR #1642 covers the other possible code path in a similar fashion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] afs commented on pull request #1641: Use distinctAdjacent for TDB 2 graph iteration (GH-1639)

Posted by GitBox <gi...@apache.org>.
afs commented on PR #1641:
URL: https://github.com/apache/jena/pull/1641#issuecomment-1332284164

   It is worth putting this in. 
   
   It isn't the code path for SPARQL for TDB2.
   
   https://github.com/apache/jena/commit/ec33bdeaebbe3d3f1361fd91f94cfef31f51a0d1
   
   `OpDatasetNames` operates on NodeIds for TDB2 (and TDB1). It also provides cancellability.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org