You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by David Reid <dr...@jetnet.co.uk> on 2000/11/08 15:32:08 UTC
Re-organise network code...
Folks,
A lot of the code in lib/apr/network_io/*/sockaddr.c is duplicated. Any
objections if I take all the truly common code and create a new sa_common.c
file in the unix directory that the other non-unix's can just include in
their sockaddr.c files?
I'm thinking of things like apr_get_port/apr_set_port and so on, i.e. not
any function that on Windows returns a windows error code...
david
Re: Re-organise network code...
Posted by David Reid <dr...@jetnet.co.uk>.
Done. Thanks to Jeff for pointing out I missed the sa-common.c file first
time around, but it should work for everyone. Please test, especially win32
and OS/2...
david
----- Original Message -----
From: "Bill Stoddard" <st...@raleigh.ibm.com>
To: <ne...@apache.org>
Sent: Wednesday, November 08, 2000 4:31 PM
Subject: Re: Re-organise network code...
> +1.
> ----- Original Message -----
> From: David Reid <dr...@jetnet.co.uk>
> To: Apache (new-httpd) <ne...@apache.org>
> Sent: Wednesday, November 08, 2000 9:32 AM
> Subject: Re-organise network code...
>
>
> > Folks,
> >
> > A lot of the code in lib/apr/network_io/*/sockaddr.c is duplicated. Any
> > objections if I take all the truly common code and create a new
sa_common.c
> > file in the unix directory that the other non-unix's can just include in
> > their sockaddr.c files?
> >
> > I'm thinking of things like apr_get_port/apr_set_port and so on, i.e.
not
> > any function that on Windows returns a windows error code...
> >
> > david
> >
>
>
Re: Re-organise network code...
Posted by Bill Stoddard <st...@raleigh.ibm.com>.
+1.
----- Original Message -----
From: David Reid <dr...@jetnet.co.uk>
To: Apache (new-httpd) <ne...@apache.org>
Sent: Wednesday, November 08, 2000 9:32 AM
Subject: Re-organise network code...
> Folks,
>
> A lot of the code in lib/apr/network_io/*/sockaddr.c is duplicated. Any
> objections if I take all the truly common code and create a new sa_common.c
> file in the unix directory that the other non-unix's can just include in
> their sockaddr.c files?
>
> I'm thinking of things like apr_get_port/apr_set_port and so on, i.e. not
> any function that on Windows returns a windows error code...
>
> david
>
Re: Re-organise network code...
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Nov 08, 2000 at 08:26:35AM -0800, rbb@covalent.net wrote:
> On Wed, 8 Nov 2000, David Reid wrote:
>
> > Folks,
> >
> > A lot of the code in lib/apr/network_io/*/sockaddr.c is duplicated. Any
> > objections if I take all the truly common code and create a new sa_common.c
> > file in the unix directory that the other non-unix's can just include in
> > their sockaddr.c files?
>
> PLEASE, always always always feel free to combine common code and make it
> really common. :-)
+1 from me, too
--
Greg Stein, http://www.lyra.org/
Re: Re-organise network code...
Posted by rb...@covalent.net.
On Wed, 8 Nov 2000, David Reid wrote:
> Folks,
>
> A lot of the code in lib/apr/network_io/*/sockaddr.c is duplicated. Any
> objections if I take all the truly common code and create a new sa_common.c
> file in the unix directory that the other non-unix's can just include in
> their sockaddr.c files?
PLEASE, always always always feel free to combine common code and make it
really common. :-)
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------