[GitHub] [airflow] ashb commented on a diff in pull request #29956: Fix some new graph bugs

["ashb (via GitHub)" <gi...@apache.org>]

ashb commented on code in PR #29956:
URL: https://github.com/apache/airflow/pull/29956#discussion_r1131230857


##########
airflow/www/static/js/dag/details/graph/utils.ts:
##########
@@ -151,15 +151,24 @@ export const buildEdges = ({
       const targetIds = e.target.split(".");
       const isSelected =
         selectedTaskId &&
-        (e.source === selectedTaskId || e.target === selectedTaskId);
+        (e.source.includes(selectedTaskId) ||
+          e.target.includes(selectedTaskId));
 
       if (
         sourceIds.length === targetIds.length &&
         sourceIds[0] === targetIds[0]
       ) {
-        const parentIds =
+        let parentIds =
           sourceIds.length > targetIds.length ? sourceIds : targetIds;
-        parentIds.pop();
+
+        if (e.target.includes("_join_id") && e.source.includes("_join_id")) {

Review Comment:
   ```suggestion
           if (e.target.endsWith("_join_id") && e.source.endsWith("_join_id")) {
   ```
   
   I think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org