You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by yuri1969 <gi...@git.apache.org> on 2017/09/17 16:39:42 UTC
[GitHub] nifi pull request #2157: NIFI-4390 - Add a keyboard shortcut for Connection....
GitHub user yuri1969 opened a pull request:
https://github.com/apache/nifi/pull/2157
NIFI-4390 - Add a keyboard shortcut for Connection...
...related dialogs
Connection related dialogs can be confirmed by the Enter key.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuri1969/nifi NIFI-4390
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2157
----
commit 8636a3864df5308ed361bf963609f48b77c48f83
Author: yuri1969 <19...@gmail.com>
Date: 2017-09-17T10:08:00Z
NIFI-4390 - Add a keyboard shortcut for Connection...
...related dialogs
Connection related dialogs can be confirmed by the Enter key.
----
---
[GitHub] nifi issue #2157: NIFI-4390 - Add a keyboard shortcut for Connection...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2157
Will review...
---
[GitHub] nifi issue #2157: NIFI-4390 - Add a keyboard shortcut for Connection...
Posted by yuri1969 <gi...@git.apache.org>.
Github user yuri1969 commented on the issue:
https://github.com/apache/nifi/pull/2157
@mcgilman This PR was created solely in order to speed up the connection creation. There was a follow-up discussion at https://issues.apache.org/jira/browse/NIFI-4390.
So I'm not sure if this particular PR is still valid.
---
[GitHub] nifi pull request #2157: NIFI-4390 - Add a keyboard shortcut for Connection....
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2157#discussion_r161299941
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.js ---
@@ -127,6 +128,10 @@
// check if the button should be disabled
if (isDisabled()) {
button.addClass('disabled-button');
+ // remove keyup listener
+ if (isDefinedAndNotNull(buttonConfig.handler) && isDefinedAndNotNull(buttonConfig.handler.keyup) && typeof buttonConfig.handler.keyup === 'function') {
+ document.removeEventListener('keyup', buttonConfig.handler.keyup, true);
--- End diff --
Is there a reason we're not using jQuery for adding/removing the event listeners? This isn't a big deal but I'd prefer to remain consistent with the rest of the code base if possible. Does it have to do with the useCapture flag you've specified here?
---
[GitHub] nifi pull request #2157: NIFI-4390 - Add a keyboard shortcut for Connection....
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2157#discussion_r161298805
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.js ---
@@ -50,6 +50,7 @@
* disabled: isDisabledFunction,
* handler: {
* click: applyHandler
+ * keyup: keyupHandler
--- End diff --
Is there a reason the `keyupHandler` is specified per button? If both Apply and Cancel have keyupHandlers specified, which one is called? Can one handler 'consume' the event and prevent further listeners from triggering?
Does it make sense to only allow a single key listener per modal? In other places, we have placed key listeners on components within a dialog. Was that not an option here? How do the key listeners effect those if configured at the same time?
---