You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/25 07:40:43 UTC

[GitHub] [couchdb-helm] willholley opened a new pull request, #99: inline GitHub actions

willholley opened a new pull request, #99:
URL: https://github.com/apache/couchdb-helm/pull/99

   <!--
   Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
   make sure you are aware of the chart technical requirements and best practices:
   
   * https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
   * https://github.com/helm/helm/tree/master/docs/chart_best_practices
   
   For a quick overview across what we will look at reviewing your PR, please read
   our review guidelines:
   
   * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
   
   Following our best practices right from the start will accelerate the review process and
   help get your PR merged quicker.
   
   When updates to your PR are requested, please add new commits and do not squash the
   history. This will make it easier to identify new changes. The PR will be squashed
   anyways when it is merged. Thanks.
   
   Please make sure you test your changes before you push them.
   -->
   
   #### What this PR does / why we need it:
   
   Why:
   
   ASF guidance is to [inline 3rd party GitHub actions](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Security) as repository submodules. This had already been done for the chart-releaser, chart-testing and kind actions, but not for the helm-setup or create-pull-request actions.
   
   This PR inlines the remaining 3rd party GitHub Actions as submodules. The official GitHub Action (checkout) remains external.
   
   It also grants the `chart-releaser` workflow `content:write` permissions to allow it to create releases.
   
   #### Which issue this PR fixes
   
   n/a - should fix the chart-releaser action which is failing on `main`
   
   #### Special notes for your reviewer:
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
   - [ ] Chart Version bumped
   - [ ] e2e tests pass
   - [ ] Variables are documented in the README.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb-helm] willholley merged pull request #99: inline GitHub actions

Posted by GitBox <gi...@apache.org>.
willholley merged PR #99:
URL: https://github.com/apache/couchdb-helm/pull/99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org