[jira] [Commented] (MJLINK-7) Code incorrectly assumes that two modules won't have the same name

["Karl Heinz Marbaise (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317243#comment-16317243 ] 

Karl Heinz Marbaise commented on MJLINK-7:
------------------------------------------

Maybe I misunderstand a thing here but based on my knowledge and the [JEP 261|http://openjdk.java.net/jeps/261] the name of modules must be unique otherwise we would have the same problems as on the classpath we already know in Java.

> Code incorrectly assumes that two modules won't have the same name
> ------------------------------------------------------------------
>
>                 Key: MJLINK-7
>                 URL: https://issues.apache.org/jira/browse/MJLINK-7
>             Project: Maven JLink Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Gili
>
> https://github.com/apache/maven-plugins/blob/bfa65c310d7f16671db672773f73fd64f05edfd0/maven-jlink-plugin/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java#L327 wrongfully assumes that two modules won't share the same name (this is legal as discussed at https://stackoverflow.com/a/46573805/14731).
> Please review this code to make sure it correctly handles multiple modules having the same name.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)