You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Andreas Beeker <ki...@apache.org> on 2018/08/13 20:46:59 UTC

Remove OPOIFSFileSystem for 4.0.0?

Hi,

NPOIFS should be quite stable in the meantime - how about removing OPOIFSFileSystem for/before 4.0.0?

Andi

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Andreas Beeker <ki...@apache.org>.
After test-removing/renaming the classes, I'm also +1 for unifying to POIFS.
The current version still contains so many (bloat/) not anymore necessary classes and its actually fun,
to remove one after another and it still works :)
... of course I try to rewrite the tests where it makes sense.

Andi

On 8/28/18 12:09 AM, Greg Woolsey wrote:
> 3->4 is already a big upgrade, with lots of other API changes (all the
> Enums, for example).  I think the direct use of NPOIFS will be small, and
> one more easy renaming migration step isn't that bad.  I'd rather not keep
> even deprecated classes around longer than necessary.
>
> On Mon, Aug 27, 2018 at 2:58 AM pj.fanning <fa...@yahoo.com> wrote:
>
>> I'd prefer if we rename the NPOIFS classes to POIFS but also keep
>> deprecated
>> NPOIFS subclasses to reduce the impact on users who will be upgrading from
>> POI 3 to 4.
>>
>>
>>
>> --
>> Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
>>

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Greg Woolsey <gr...@gmail.com>.
3->4 is already a big upgrade, with lots of other API changes (all the
Enums, for example).  I think the direct use of NPOIFS will be small, and
one more easy renaming migration step isn't that bad.  I'd rather not keep
even deprecated classes around longer than necessary.

On Mon, Aug 27, 2018 at 2:58 AM pj.fanning <fa...@yahoo.com> wrote:

> I'd prefer if we rename the NPOIFS classes to POIFS but also keep
> deprecated
> NPOIFS subclasses to reduce the impact on users who will be upgrading from
> POI 3 to 4.
>
>
>
> --
> Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by "pj.fanning" <fa...@yahoo.com>.
I'd prefer if we rename the NPOIFS classes to POIFS but also keep deprecated
NPOIFS subclasses to reduce the impact on users who will be upgrading from
POI 3 to 4.



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Tim Allison <ta...@apache.org>.
+1.  Thank you, Andi!
On Mon, Aug 27, 2018 at 5:52 AM Alain FAGOT BÉAREZ <ab...@for-scala.it> wrote:
>
> +1 for full refactoring to POIFS*
>
> ⁣Gesendet mit BlueMail
>
>
> -------- Originale Nachricht --------
> Von: Andreas Beeker <ki...@apache.org>
> Gesendet: Sun Aug 26 19:06:02 GMT-03:00 2018
> An: dev@poi.apache.org
> Betreff: Re: Remove OPOIFSFileSystem for 4.0.0?
>
> After OPOIFS* is now removed, should I rename/normalize/refactor NPOIFS* to POIFS*?
>
> Andi
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Alain FAGOT BÉAREZ <ab...@for-scala.it>.
+1 for full refactoring to POIFS*

⁣Gesendet mit BlueMail ​


-------- Originale Nachricht --------
Von: Andreas Beeker <ki...@apache.org>
Gesendet: Sun Aug 26 19:06:02 GMT-03:00 2018
An: dev@poi.apache.org
Betreff: Re: Remove OPOIFSFileSystem for 4.0.0?

After OPOIFS* is now removed, should I rename/normalize/refactor NPOIFS* to POIFS*?

Andi

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Andreas Beeker <ki...@apache.org>.
After OPOIFS* is now removed, should I rename/normalize/refactor NPOIFS* to POIFS*?

Andi

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by kiwiwings <ki...@apache.org>.
Javen O'Neal-2 wrote
> How many lines of code can we delete by removing this class?

Quite a few ... The issue came to my mind, as I've had a look into #61677
and didn't want to (try to) fix it in two areas. I've started to remove the
OPOIFS* classes yesterday, but this is not so trivial as I thought it would
be ... e.g. IIRC, I think the POIFSWriterListener is not implemented and
OPOIFS is used in a few other places too, where I thought NPOIFS would be
used.

So depending on when we get feedback on #62564 / TIKA-2693, I would postpone
it after 4.0.0, so we can push out 4.0.0.

Andi.



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Javen O'Neal <on...@apache.org>.
+1.
How many lines of code can we delete by removing this class?

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by Alain FAGOT BÉAREZ <ab...@for-scala.it>.
+1 for removal before 4.0.0

⁣Gesendet mit BlueMail ​


-------- Originale Nachricht --------
Von: "pj.fanning" <fa...@yahoo.com>
Gesendet: Mon Aug 13 17:54:14 GMT-03:00 2018
An: dev@poi.apache.org
Betreff: Re: Remove OPOIFSFileSystem for 4.0.0?

+1 for 4.0.0 change



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: Remove OPOIFSFileSystem for 4.0.0?

Posted by "pj.fanning" <fa...@yahoo.com>.
+1 for 4.0.0 change



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org