You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/08 09:24:43 UTC
[GitHub] zeppelin pull request #1990: [ZEPPELIN-2072] Home Screen doesn't work on shi...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1990
[ZEPPELIN-2072] Home Screen doesn't work on shiro.
### What is this PR for?
The home screen is a notebook for use as homepage.
It is the zeppelin.notebook.homescreen variable in `conf/zeppelin-site.xml` or `conf/zeppelin-env.sh`.
But currently zeppelin.notebook.homescreen variable doesn't work on shiro until refreshing window.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2072](https://issues.apache.org/jira/browse/ZEPPELIN-2072)
### How should this be tested?
1. Set zeppelin.notebook.homescreen variable in `conf/zeppelin-site.xml` or `conf/zeppelin-env.sh`.
2. Turn on shiro.
3. Start zeppelin-daemon.
4. Login your account and make sure whether homepage is changed or not.
### Screenshots (if appropriate)
[ Before ]
[ After ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2072_homescreen_shiro
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1990.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1990
----
commit 35625c41acd14a1fa801eba7898f40f371ca3bcc
Author: soralee <so...@zepl.com>
Date: 2017-02-08T08:24:12Z
fix homescreen on shiro
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1990: [ZEPPELIN-2072] Home Screen doesn't work on shiro.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1990
Thanks @soralee for the fix!
Tested and LGTM. CI failure looks not related.
Merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1990: [ZEPPELIN-2072] Home Screen doesn't work on shi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1990
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1990: [ZEPPELIN-2072] Home Screen doesn't work on shiro.
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1990
Thanks for taking care of @Leemoonsoo :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---