[GitHub] storm issue #2228: fix class cast exception when nimbus seeds is not an arra...

[srdo <gi...@git.apache.org>]

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2228
  
    Hi @ecararus. Could you clarify a bit how the changes fix the issue you were seeing, and maybe also which Storm version you were seeing the issue on?
    
    The default setting for nimbus.seeds is ["localhost"] (https://github.com/apache/storm/blob/master/conf/defaults.yaml#L61), which works fine for me when I try it locally, so I don't think there's a problem specifying a single host. We assume the configuration is a String list here https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/Config.java#L1052.
    
    The change in L118 is checking if the config is a String[], which I would assume doesn't work since it is usually a `List<String>`? If you need to be able to write `nimbus.seeds: "host"` instead of `nimbus.seeds: ["host"]`, I think you should update the Config with this annotation https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/Config.java#L1120.
    
    Please also create an issue on JIRA https://issues.apache.org/jira and update your commit message and this PR's title to reflect the issue number (see the other PRs for example of what this should look like). Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---