You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2016/02/03 01:49:33 UTC

Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 

Diff: https://reviews.apache.org/r/43125/diff/


Testing
-------

Manual testing done.


Thanks,

Aravindan Vijayan

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 3, 2016, 1 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py, line 32
> > <https://reviews.apache.org/r/43125/diff/1/?file=1230272#file1230272line32>
> >
> >     May need to create /usr/share/grafana/public/app/plugins/datasource if it doesn't exist.

Alejandro, this is just an INITIAL PATCH that I used to test with. The Execute statements in install will not be there. We will be installing through usual rpm mechanism(another bug), and will be calling install.packages()


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117535
-----------------------------------------------------------


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 3, 2016, 1 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py, line 31
> > <https://reviews.apache.org/r/43125/diff/1/?file=1230272#file1230272line31>
> >
> >     Will eventually need to pick this up from a different location.

Just an INITIAL PATCH that I used to test with. The Execute statements in install will not be there. We will be installing through usual rpm mechanism(another bug), and will be calling install.packages()


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117535
-----------------------------------------------------------


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 3, 2016, 1 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py, line 26
> > <https://reviews.apache.org/r/43125/diff/1/?file=1230272#file1230272line26>
> >
> >     In a kerberized environment, will need to kinit.

The plan is to not support Kerberos for grafana for the first version.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117535
-----------------------------------------------------------


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117535
-----------------------------------------------------------



Awesome, great to see this!


ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana (line 60)
<https://reviews.apache.org/r/43125/#comment178736>

    Will need to test this with ambari agent running as non-root.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (line 388)
<https://reviews.apache.org/r/43125/#comment178739>

    Why not put these in a list and just iterate over them?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 21)
<https://reviews.apache.org/r/43125/#comment178740>

    Use explicit import instead of *



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 26)
<https://reviews.apache.org/r/43125/#comment178744>

    In a kerberized environment, will need to kinit.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 31)
<https://reviews.apache.org/r/43125/#comment178741>

    Will eventually need to pick this up from a different location.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 32)
<https://reviews.apache.org/r/43125/#comment178742>

    May need to create /usr/share/grafana/public/app/plugins/datasource if it doesn't exist.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 44)
<https://reviews.apache.org/r/43125/#comment178743>

    Should have "/usr/sbin/ambari-metrics-grafana" as a variable


- Alejandro Fernandez


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Dmytro Sen <ds...@hortonworks.com>.

> On Фев. 3, 2016, 12:57 п.п., Dmytro Sen wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml, line 69
> > <https://reviews.apache.org/r/43125/diff/1/?file=1230270#file1230270line69>
> >
> >     Cardinality 1 means - it should be always installed. If we set 0+ , user can decide to install grafana or not

or cardinality 0-1


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117610
-----------------------------------------------------------


On Фев. 3, 2016, 12:49 д.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Фев. 3, 2016, 12:49 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117610
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml (line 69)
<https://reviews.apache.org/r/43125/#comment178855>

    Cardinality 1 means - it should be always installed. If we set 0+ , user can decide to install grafana or not


- Dmytro Sen


On Фев. 3, 2016, 12:49 д.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Фев. 3, 2016, 12:49 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 3, 2016, 10:23 a.m., Dmytro Sen wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py, line 31
> > <https://reviews.apache.org/r/43125/diff/1/?file=1230272#file1230272line31>
> >
> >     We should install ambari-metrics-grafana.rpm
> >     
> >     Lets just remove these Excecute's from install() and install ambari-metrics-grafana.rpm manually

Dmitry Sen, this is just an INITIAL PATCH that I used to test with. The Execute statements in install will not be there. Keeping this issue open. Will fix this when I have integrated with your patch.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117607
-----------------------------------------------------------


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117607
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 31)
<https://reviews.apache.org/r/43125/#comment178853>

    We should install ambari-metrics-grafana.rpm
    
    Lets just remove these Excecute's from install() and install ambari-metrics-grafana.rpm manually


- Dmytro Sen


On Фев. 3, 2016, 12:49 д.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Фев. 3, 2016, 12:49 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117536
-----------------------------------------------------------




ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana (line 72)
<https://reviews.apache.org/r/43125/#comment178738>

    This is not needed since we are not installing a default service.



ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana (line 80)
<https://reviews.apache.org/r/43125/#comment178756>

    This might also be unnecessary.


Rest of the changes look good.

- Sid Wagle


On Feb. 3, 2016, 12:49 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 4, 2016, 4:52 a.m., Sumit Mohanty wrote:
> > ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana, line 1
> > <https://reviews.apache.org/r/43125/diff/3/?file=1231865#file1231865line1>
> >
> >     Why is this file needed?

This is the startup script provided by Grafana. It has been modified to suit Ambari and AMS needs.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117762
-----------------------------------------------------------


On Feb. 4, 2016, 8:09 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 4, 2016, 4:52 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py, line 33
> > <https://reviews.apache.org/r/43125/diff/3/?file=1231870#file1231870line33>
> >
> >     This path may need to be explicitly created first. How about non-root ambari server?

The first patch was an Initial one, with hardcoded steps for INSTALL step. These statements are no longer there.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117762
-----------------------------------------------------------


On Feb. 4, 2016, 8:09 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117762
-----------------------------------------------------------




ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana (line 1)
<https://reviews.apache.org/r/43125/#comment179038>

    Why is this file needed?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml (line 69)
<https://reviews.apache.org/r/43125/#comment179037>

    Is grafana expected to be optional? Can Master be unselected when deploying using UI?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 32)
<https://reviews.apache.org/r/43125/#comment179039>

    Any plan to package it with AMS/Ambari itself?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 33)
<https://reviews.apache.org/r/43125/#comment179040>

    This path may need to be explicitly created first. How about non-root ambari server?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 45)
<https://reviews.apache.org/r/43125/#comment179041>

    why don't we call stop() instead of duplicating stop logic?


- Sumit Mohanty


On Feb. 3, 2016, 11:05 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 11:05 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.

> On Feb. 4, 2016, 10:24 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini, line 151
> > <https://reviews.apache.org/r/43125/diff/5/?file=1233163#file1233163line151>
> >
> >     Ambari sounds better.

Will customize Grafana for AMS and Ambari through a follow up patch.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117892
-----------------------------------------------------------


On Feb. 4, 2016, 9:35 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 9:35 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py cf498ec 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117892
-----------------------------------------------------------



Can you please add some unit tests. Changes look good.


ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana (line 21)
<https://reviews.apache.org/r/43125/#comment179144>

    .pid ?



ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini (line 151)
<https://reviews.apache.org/r/43125/#comment179145>

    Ambari sounds better.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 66)
<https://reviews.apache.org/r/43125/#comment179148>

    Is this required? This component does not support kerberization.


- Sid Wagle


On Feb. 4, 2016, 9:35 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 9:35 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py cf498ec 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review118008
-----------------------------------------------------------


Ship it!




Lets commit it as is. It'll be updated multiple times in other AMS grafana jiras.

- Dmytro Sen


On Фев. 4, 2016, 11:54 п.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Фев. 4, 2016, 11:54 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 5067454 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java 8cbc56b 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py cf498ec 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
>   ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json f421aec 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117931
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 4, 2016, 11:54 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:54 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 5067454 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java 8cbc56b 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py cf498ec 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
>   ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json f421aec 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 11:54 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Changes
-------

Addressed review comments. 

Added python unit tests for Grafana.

Fixed an issue in Collector while requested for precision data.


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 5067454 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java 8cbc56b 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py cf498ec 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
  ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json f421aec 

Diff: https://reviews.apache.org/r/43125/diff/


Testing
-------

Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.


Thanks,

Aravindan Vijayan

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 9:35 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Changes
-------

Fix issues in package installation.


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py cf498ec 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py a1d6a1d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 

Diff: https://reviews.apache.org/r/43125/diff/


Testing
-------

Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.


Thanks,

Aravindan Vijayan

Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 8:09 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Changes
-------

Integrated with AMBARI-14902 : Make AMS Grafana component available as a repo package

Added role command dependency between Metrics Collector and Grafana.


Summary (updated)
-----------------

AMBARI-14892 : Add Grafana as a component to AMS


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 

Diff: https://reviews.apache.org/r/43125/diff/


Testing (updated)
-------

Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the patch.


Thanks,

Aravindan Vijayan

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 11:05 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Changes
-------

Fix issues with GRAFANA STOP.


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 

Diff: https://reviews.apache.org/r/43125/diff/


Testing
-------

Manual testing done.


Thanks,

Aravindan Vijayan

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 8:55 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.


Changes
-------

Addressed review comments.


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 

Diff: https://reviews.apache.org/r/43125/diff/


Testing
-------

Manual testing done.


Thanks,

Aravindan Vijayan

Re: Review Request 43125: [INITIAL PATCH] AMBARI-14892 Add Grafana as a component to AMS

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review117624
-----------------------------------------------------------


Ship it!




+1 for initital patch.

- Dmytro Sen


On Фев. 3, 2016, 12:49 д.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Фев. 3, 2016, 12:49 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml 48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py 59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py d446baa 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>